Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Refactor vuln scan into separate yaml #41528

Merged
merged 1 commit into from
Apr 27, 2023

Conversation

sealesj
Copy link
Contributor

@sealesj sealesj commented Apr 26, 2023

This removes the vuln scanning action from the scorecards yaml and into its own file. The additional file already existed but was not updated.

Fixes:
b/246821537

If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@sealesj sealesj requested a review from godofredoc April 27, 2023 14:45
Copy link
Contributor

@godofredoc godofredoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@sealesj sealesj added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 27, 2023
@auto-submit auto-submit bot merged commit 3d6d915 into flutter:main Apr 27, 2023
@sealesj sealesj deleted the refactor-vuln-scan branch April 27, 2023 15:53
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 27, 2023
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Apr 27, 2023
…125637)

flutter/engine@381f714...3d6d915

2023-04-27 [email protected] Refactor vuln scan into separate yaml (flutter/engine#41528)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
autosubmit Merge PR when tree becomes green via auto submit App
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants