This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Revert "Replace deprecated and internal Skia EncodedImage calls with public versions" #41595
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jason-simmons
approved these changes
Apr 28, 2023
zanderso
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 28, 2023
…alls with public versions" (flutter/engine#41595)
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Apr 28, 2023
…125714) flutter/engine@98b6fab...2a84ea5 2023-04-28 [email protected] Revert "Replace deprecated and internal Skia EncodedImage calls with public versions" (flutter/engine#41595) 2023-04-28 [email protected] Roll buildroot to c96c9d4641714301fab450a5f3b0f3c42712e1e3 (flutter/engine#41589) 2023-04-28 [email protected] [platform_view] Only dispose view when it is removed from the composition order (flutter/engine#41521) 2023-04-28 [email protected] Determine lifecycle by looking at window focus also (flutter/engine#41094) 2023-04-28 [email protected] Increase timeout for clang-tidy on mac (flutter/engine#41588) 2023-04-28 [email protected] [Impeller] Always enable validation for goldens (flutter/engine#41574) 2023-04-28 [email protected] fuchsia: do not read version_history.json (flutter/engine#41585) 2023-04-28 [email protected] Roll Dart SDK from c7160d4ea0b7 to 8e9bf2bb9878 (5 revisions) (flutter/engine#41586) 2023-04-28 [email protected] Replace deprecated and internal Skia EncodedImage calls with public versions (flutter/engine#41368) 2023-04-28 [email protected] Roll Skia from 05d09f28250a to 9867fa253064 (18 revisions) (flutter/engine#41584) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
|
What issues were there? Why did no unit tests fail? |
kjlubick
added a commit
to kjlubick/engine
that referenced
this pull request
May 1, 2023
…ls with public versions" (flutter#41595)" This reverts commit 2a84ea5.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #41368
This is blocking rolls into the framework. Let's revert until we sort out whether there's a workaround for the change to the unpremultiplied alpha issue.