Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

setupDefultFontManager correctly clear out cache #42178

Merged
merged 3 commits into from
Jun 13, 2023
Merged

setupDefultFontManager correctly clear out cache #42178

merged 3 commits into from
Jun 13, 2023

Conversation

chunhtai
Copy link
Contributor

@chunhtai chunhtai commented May 19, 2023 •
edited
Loading

fixes flutter/flutter#123483

Not entirely sure if this really fix the flake as I can't reproduce locally. My guess to the flake is that the setDefaultfontmgr should only be called once during the life time of the app. The setDefaultfontmgr can be remove at the call site, since it is already called during setup

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@chunhtai chunhtai requested a review from chinmaygarde May 23, 2023 18:35
chinmaygarde
chinmaygarde approved these changes May 25, 2023
View reviewed changes
Copy link
Member

@chinmaygarde chinmaygarde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we make whatever SetupDefaultFontManager is doing perform the static initialization instead? I don't know how to reason about the correctness of this patch.

chinmaygarde
chinmaygarde suggested changes May 25, 2023
View reviewed changes
Copy link
Member

@chinmaygarde chinmaygarde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops incorrectly approved.

@chinmaygarde
Copy link
Member

Perhaps flutter::FontCollection can gracefully handle multiple calls? That might be easier to test too.

@chunhtai
Copy link
Contributor Author

chunhtai commented May 25, 2023 •
edited
Loading

Perhaps flutter::FontCollection can gracefully handle multiple calls? That might be easier to test too.

yes I think that is possible. For some reason I was thinking txt is not in the engine repo, but it is. I still find it weird that we would call SetupDefaultFontManager multiple time though. I will see what I can come up with

@chinmaygarde
Copy link
Member

Any updates on moving the check into txt?

@chunhtai chunhtai marked this pull request as draft June 1, 2023 20:21
@chunhtai chunhtai requested a review from chinmaygarde June 6, 2023 18:23
@chunhtai chunhtai marked this pull request as ready for review June 6, 2023 18:23
@chunhtai chunhtai changed the title Removes unnecesary setDefultFontManager setupDefultFontManager correctly clear out cache Jun 6, 2023
chunhtai
chunhtai commented Jun 6, 2023
View reviewed changes
@chunhtai chunhtai requested a review from zanderso June 9, 2023 16:28
@chunhtai chunhtai added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 9, 2023
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jun 9, 2023
@auto-submit
Copy link
Contributor

auto-submit bot commented Jun 9, 2023

auto label is removed for flutter/engine, pr: 42178, due to This PR has not met approval requirements for merging. Changes were requested by {chinmaygarde}, please make the needed changes and resubmit this PR.
You are a member of flutter-hackers and need 1 more review(s) in order to merge this PR.

  • Merge guidelines: You need at least one approved review if you are already part of flutter-hackers or two member reviews if you are not a flutter-hacker before re-applying the autosubmit label. Reviewers: If you left a comment approving, please use the "approve" review action instead.

@chunhtai chunhtai added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 13, 2023
@auto-submit auto-submit bot merged commit b18778c into flutter:main Jun 13, 2023
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 14, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 14, 2023
@engine-flutter-autoroll
b18778c88 setupDefultFontManager correctly clear out cache (flutter/e…
f402547 
…ngine#42178)
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Jun 14, 2023
@engine-flutter-autoroll
Roll Flutter Engine from 66a5761412f9 to 727b4413fe6f (10 revisions) (#…
4fe84d7 
…128841)

flutter/engine@66a5761...727b441

2023-06-13 [email protected] Reland "[ios_platform_view] only recycle maskView when the view is applying mutators #42115" (flutter/engine#42823)
2023-06-13 [email protected] Roll Dart SDK from 41234fa4b22d to 2465228c0c21 (1 revision) (flutter/engine#42822)
2023-06-13 [email protected] [Impeller] Added cache for command buffers in vulkan (flutter/engine#42793)
2023-06-13 [email protected] setupDefultFontManager correctly clear out cache (flutter/engine#42178)
2023-06-13 [email protected] [Impeller] Reland attempt Vulkan setup and fallback to GLES. (flutter/engine#42820)
2023-06-13 [email protected] Added CI step for building with validation layers (flutter/engine#42724)
2023-06-13 [email protected] [Impeller] Null check for the device holder in the Vulkan context destructor (flutter/engine#42821)
2023-06-13 [email protected] Add missing includes (flutter/engine#42812)
2023-06-13 [email protected] Roll Dart SDK from 4dce1093ad94 to 41234fa4b22d (1 revision) (flutter/engine#42810)
2023-06-13 [email protected] [iOS][Keyboard] Wait vsync on UI thread and update viewport inset to avoid jitter. (flutter/engine#42312)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@chinmaygarde chinmaygarde chinmaygarde approved these changes

@zanderso zanderso zanderso approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App needs tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[engine] Host Tests for host_debug_unopt is flaky

3 participants

@chunhtai @chinmaygarde @zanderso