Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Again a two-word super tiny typo #42181

Merged
merged 2 commits into from
May 22, 2023
Merged

Again a two-word super tiny typo #42181

merged 2 commits into from
May 22, 2023

Conversation

fzyzcjy
Copy link
Contributor

@fzyzcjy fzyzcjy commented May 20, 2023 •
edited
Loading

Find this when reading source code today...

Btw, what about introducing a spell checker to Flutter source code? ;)

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard
Copy link

This pull request was opened against a branch other than main. Since Flutter pull requests should not normally be opened against branches other than main, I have changed the base to main. If this was intended, you may modify the base back to master. See the Release Process for information about how other branches get updated.

Reviewers: Use caution before merging pull requests to branches other than main, unless this is an intentional hotfix/cherrypick.

@flutter-dashboard flutter-dashboard bot changed the base branch from master to main May 20, 2023 01:20
@zanderso zanderso merged commit ac29a74 into flutter:main May 22, 2023
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 22, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 22, 2023
@engine-flutter-autoroll
ac29a74d6 Again a two-word super tiny typo (flutter/engine#42181)
62f4196
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 23, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 23, 2023
@engine-flutter-autoroll
ac29a74d6 Again a two-word super tiny typo (flutter/engine#42181)
52875fd
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request May 23, 2023
@engine-flutter-autoroll
Roll Flutter Engine from a342a9186e69 to 2a325eed77d0 (7 revisions) (#…
194d30a 
…127364)

flutter/engine@a342a91...2a325ee

2023-05-22 [email protected] Roll Dart SDK from b3e1eeda4918 to 1ca8f8368ecc (5 revisions) (flutter/engine#42224)
2023-05-22 [email protected] [Impeller] Return image decoder error messages to the Dart API (flutter/engine#42175)
2023-05-22 [email protected] Again a two-word super tiny typo (flutter/engine#42181)
2023-05-22 [email protected] Reland "[ios_platform_view] only recycle maskView when the view is applying mutators #41573" (flutter/engine#42115)
2023-05-22 [email protected] [Impeller] Use untransformed text bounds to calculate the size of ColorSourceTextContents (flutter/engine#42142)
2023-05-22 [email protected] [Impeller] Add UV compute shader. (flutter/engine#42192)
2023-05-22 [email protected] [Impeller] remove final cmd buffer waitUntilScheduled on physical iOS (flutter/engine#42160)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 23, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 23, 2023
@engine-flutter-autoroll
ac29a74d6 Again a two-word super tiny typo (flutter/engine#42181)
3081bb6
zanderso pushed a commit to flutter/flutter that referenced this pull request May 23, 2023
@engine-flutter-autoroll
Manual roll Flutter Engine from a342a9186e69 to 2586cbeeae37 (14 revi…
dd07c61 
…sions) (#127369)

Manual roll requested by [email protected]

flutter/engine@a342a91...2586cbe

2023-05-23 [email protected] Revert "[ios_platform_view]
only recycle maskView when the view is applying mutators #41573"
(flutter/engine#42231)
2023-05-23 [email protected] Roll Skia from ac87929b3d2e to
6a57876d0e44 (2 revisions) (flutter/engine#42230)
2023-05-23 [email protected] Roll Fuchsia Mac SDK from
QAwORJOkyNl4J3x4Y... to DzmjiSg6XC0JUfbKP... (flutter/engine#42227)
2023-05-23 [email protected] Manual roll Dart SDK from
b3e1eeda4918 to 1ca8f8368ecc (5 revisions) (flutter/engine#42229)
2023-05-23 [email protected] Roll Skia from d448fe07ea46 to
ac87929b3d2e (8 revisions) (flutter/engine#42226)
2023-05-23 [email protected] Make FML_LOG safe from static
initialization (flutter/engine#42219)
2023-05-23 [email protected] [fuchsia] Bind ChildViewWatcher on
platform thread (flutter/engine#42222)
2023-05-22 [email protected] Roll Dart SDK from
b3e1eeda4918 to 1ca8f8368ecc (5 revisions) (flutter/engine#42224)
2023-05-22 [email protected] [Impeller] Return
image decoder error messages to the Dart API (flutter/engine#42175)
2023-05-22 [email protected] Again a two-word
super tiny typo (flutter/engine#42181)
2023-05-22 [email protected] Reland "[ios_platform_view] only recycle
maskView when the view is applying mutators #41573"
(flutter/engine#42115)
2023-05-22 [email protected] [Impeller] Use
untransformed text bounds to calculate the size of
ColorSourceTextContents (flutter/engine#42142)
2023-05-22 [email protected] [Impeller] Add UV compute shader.
(flutter/engine#42192)
2023-05-22 [email protected] [Impeller] remove final cmd buffer
waitUntilScheduled on physical iOS (flutter/engine#42160)

Also rolling transitive DEPS:
  fuchsia/sdk/core/mac-amd64 from QAwORJOkyNl4 to DzmjiSg6XC0J

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that
a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
CaseyHillers pushed a commit to CaseyHillers/flutter that referenced this pull request May 24, 2023
@engine-flutter-autoroll
Roll Flutter Engine from a342a9186e69 to 2a325eed77d0 (7 revisions) (f…
802c4a1 
…lutter#127364)

flutter/engine@a342a91...2a325ee

2023-05-22 [email protected] Roll Dart SDK from b3e1eeda4918 to 1ca8f8368ecc (5 revisions) (flutter/engine#42224)
2023-05-22 [email protected] [Impeller] Return image decoder error messages to the Dart API (flutter/engine#42175)
2023-05-22 [email protected] Again a two-word super tiny typo (flutter/engine#42181)
2023-05-22 [email protected] Reland "[ios_platform_view] only recycle maskView when the view is applying mutators flutter#41573" (flutter/engine#42115)
2023-05-22 [email protected] [Impeller] Use untransformed text bounds to calculate the size of ColorSourceTextContents (flutter/engine#42142)
2023-05-22 [email protected] [Impeller] Add UV compute shader. (flutter/engine#42192)
2023-05-22 [email protected] [Impeller] remove final cmd buffer waitUntilScheduled on physical iOS (flutter/engine#42160)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
CaseyHillers pushed a commit to CaseyHillers/flutter that referenced this pull request May 24, 2023
@engine-flutter-autoroll
Manual roll Flutter Engine from a342a9186e69 to 2586cbeeae37 (14 revi…
22e1b6d 
…sions) (flutter#127369)

Manual roll requested by [email protected]

flutter/engine@a342a91...2586cbe

2023-05-23 [email protected] Revert "[ios_platform_view]
only recycle maskView when the view is applying mutators flutter#41573"
(flutter/engine#42231)
2023-05-23 [email protected] Roll Skia from ac87929b3d2e to
6a57876d0e44 (2 revisions) (flutter/engine#42230)
2023-05-23 [email protected] Roll Fuchsia Mac SDK from
QAwORJOkyNl4J3x4Y... to DzmjiSg6XC0JUfbKP... (flutter/engine#42227)
2023-05-23 [email protected] Manual roll Dart SDK from
b3e1eeda4918 to 1ca8f8368ecc (5 revisions) (flutter/engine#42229)
2023-05-23 [email protected] Roll Skia from d448fe07ea46 to
ac87929b3d2e (8 revisions) (flutter/engine#42226)
2023-05-23 [email protected] Make FML_LOG safe from static
initialization (flutter/engine#42219)
2023-05-23 [email protected] [fuchsia] Bind ChildViewWatcher on
platform thread (flutter/engine#42222)
2023-05-22 [email protected] Roll Dart SDK from
b3e1eeda4918 to 1ca8f8368ecc (5 revisions) (flutter/engine#42224)
2023-05-22 [email protected] [Impeller] Return
image decoder error messages to the Dart API (flutter/engine#42175)
2023-05-22 [email protected] Again a two-word
super tiny typo (flutter/engine#42181)
2023-05-22 [email protected] Reland "[ios_platform_view] only recycle
maskView when the view is applying mutators flutter#41573"
(flutter/engine#42115)
2023-05-22 [email protected] [Impeller] Use
untransformed text bounds to calculate the size of
ColorSourceTextContents (flutter/engine#42142)
2023-05-22 [email protected] [Impeller] Add UV compute shader.
(flutter/engine#42192)
2023-05-22 [email protected] [Impeller] remove final cmd buffer
waitUntilScheduled on physical iOS (flutter/engine#42160)

Also rolling transitive DEPS:
  fuchsia/sdk/core/mac-amd64 from QAwORJOkyNl4 to DzmjiSg6XC0J

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that
a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@zanderso zanderso zanderso approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fzyzcjy @zanderso