Delete WeakPtrFactory from GPUSurfaceVulkanImpeller #42710
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
This PR only deletes code, but also results in some reformating that makes it look like it's not a "pure" delete. |
|
test-exempt: code deletion |
…128643) flutter/engine@b037db2...962d78e 2023-06-10 [email protected] Roll Fuchsia Linux SDK from 1ODZdNPvGxBrgnCzf... to pd1VfyK_WEW6tu8WI... (flutter/engine#42723) 2023-06-10 [email protected] Roll ANGLE from acdf872299ba to 10380f4ba473 (1 revision) (flutter/engine#42722) 2023-06-10 [email protected] Roll Fuchsia Mac SDK from EInl_eQkJekqc-gfW... to Otfnr8SATDVN_7BuI... (flutter/engine#42721) 2023-06-10 [email protected] Roll ANGLE from a01a566c489b to acdf872299ba (1 revision) (flutter/engine#42719) 2023-06-10 [email protected] Roll Clang from 6d667d4b261e to 7f374b6902fa (flutter/engine#42718) 2023-06-10 [email protected] Manual roll Dart SDK from d5b39a8385f9 to 9d705a5391b2 (7 revisions) (flutter/engine#42716) 2023-06-09 [email protected] [Impeller] Added helper messaging around validation usage (flutter/engine#42708) 2023-06-09 [email protected] Fix an archive name in windows_host_engine config (flutter/engine#42709) 2023-06-09 [email protected] Roll ANGLE from 72df42832ee4 to a01a566c489b (3 revisions) (flutter/engine#42712) 2023-06-09 [email protected] Delete WeakPtrFactory from GPUSurfaceVulkanImpeller (flutter/engine#42710) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from 1ODZdNPvGxBr to pd1VfyK_WEW6 fuchsia/sdk/core/mac-amd64 from EInl_eQkJekq to Otfnr8SATDVN If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Should fix flutter/flutter#128618.
This is unused - if it were used we'd have to be careful about deleting the object on the same thread it's created on.