This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Use full 4x4 matrix transforms in TransformLayer #43536
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chinmaygarde
approved these changes
Jul 11, 2023
dnfield
reviewed
Jul 11, 2023
| @@ -47,7 +46,7 @@ void TransformLayer::Preroll(PrerollContext* context) { | |||
| SkRect child_paint_bounds = SkRect::MakeEmpty(); | |||
| PrerollChildren(context, &child_paint_bounds); | |||
|
|
|||
| transform_.mapRect(&child_paint_bounds); | |||
| transform_.asM33().mapRect(&child_paint_bounds); | |||
There was a problem hiding this comment.
We should port over SkMatrixPriv::mapRect for this.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 11, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jul 11, 2023
…130307) flutter/engine@95316fb...312e481 2023-07-11 [email protected] Roll Skia from 76daa2a33fa5 to bbe71d71e576 (1 revision) (flutter/engine#43541) 2023-07-11 [email protected] Use full 4x4 matrix transforms in TransformLayer (flutter/engine#43536) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
kjlubick
pushed a commit
to kjlubick/engine
that referenced
this pull request
Jul 14, 2023
Fixes: flutter/flutter#82961 Fixes: flutter/flutter#113346 The fix was a simple fallout from the previous work to add support for SkM44 throughout the DL and Diff mechanisms (see flutter/flutter#82955, flutter/flutter#116198, flutter#37394) Tested with its own existing and new unit tests as well as the test case from flutter/flutter#113346
2 tasks
gbtb16
pushed a commit
to gbtb16/flutter
that referenced
this pull request
Nov 6, 2023
…lutter#130307) flutter/engine@95316fb...312e481 2023-07-11 [email protected] Roll Skia from 76daa2a33fa5 to bbe71d71e576 (1 revision) (flutter/engine#43541) 2023-07-11 [email protected] Use full 4x4 matrix transforms in TransformLayer (flutter/engine#43536) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: flutter/flutter#82961
Fixes: flutter/flutter#113346
The fix was a simple fallout from the previous work to add support for SkM44 throughout the DL and Diff mechanisms (see flutter/flutter#82955, flutter/flutter#116198, #37394)
Tested with its own existing and new unit tests as well as the test case from flutter/flutter#113346