This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Impeller] Do not use clear color optimization if the subpass is being collapsed into its parent #43878
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
jason-simmons
force-pushed
the
bug_130824
branch
from
8170376 to
6ace374
Compare
There was a problem hiding this comment.
DBC: it would be preferable from a performance perspective to still collapse the parent pass and instead undo the clear color optimization. The pass collapse avoids an expensive allocation and texture fill while the clear color optimization only removes a draw call.
jason-simmons
changed the title
jason-simmons
force-pushed
the
bug_130824
branch
from
6ace374 to
4ba944b
Compare
|
Changed this to disable the clear color optimization for subpasses that are collapsed into the parent |
…g collapsed into its parent The InlinePassContext will not apply the clear color within a parent pass that is already in progress. Fixes flutter/flutter#130824
jason-simmons
force-pushed
the
bug_130824
branch
from
4ba944b to
5d6676d
Compare
jason-simmons
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 21, 2023
…ss is being collapsed into its parent (flutter/engine#43878)
fluttermirroringbot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jul 22, 2023
…131101) flutter/engine@2d8cff4...840bcc3 2023-07-21 [email protected] Roll ANGLE from f586ec98d924 to 938ee1e80fc8 (1 revision) (flutter/engine#43912) 2023-07-21 [email protected] Roll ANGLE from 085f25bbb1e3 to f586ec98d924 (1 revision) (flutter/engine#43908) 2023-07-21 [email protected] Roll Fuchsia Mac SDK from WH3AaCa4DtVERww1v... to rMFZIJYvVmXEBGCay... (flutter/engine#43907) 2023-07-21 [email protected] [Impeller] Do not use clear color optimization if the subpass is being collapsed into its parent (flutter/engine#43878) 2023-07-21 [email protected] Roll Skia from 2e28fe9de378 to 359d4726e423 (1 revision) (flutter/engine#43906) 2023-07-21 [email protected] [Impeller] Disable color attachment removal for clips on VK (flutter/engine#43905) 2023-07-21 [email protected] [Impeller] Add a way to query the gfx backend type. (flutter/engine#43837) 2023-07-21 [email protected] Roll ANGLE from 82d68c577b1d to 085f25bbb1e3 (1 revision) (flutter/engine#43904) 2023-07-21 [email protected] Roll ANGLE from 2e190280f5c5 to 82d68c577b1d (1 revision) (flutter/engine#43901) 2023-07-21 [email protected] Roll Skia from 497326dc66cd to 2e28fe9de378 (2 revisions) (flutter/engine#43900) 2023-07-21 [email protected] Roll Skia from 1f84e9d51bba to 497326dc66cd (1 revision) (flutter/engine#43899) Also rolling transitive DEPS: fuchsia/sdk/core/mac-amd64 from WH3AaCa4DtVE to rMFZIJYvVmXE If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
LouiseHsu
pushed a commit
to LouiseHsu/flutter
that referenced
this pull request
Jul 31, 2023
…lutter#131101) flutter/engine@2d8cff4...840bcc3 2023-07-21 [email protected] Roll ANGLE from f586ec98d924 to 938ee1e80fc8 (1 revision) (flutter/engine#43912) 2023-07-21 [email protected] Roll ANGLE from 085f25bbb1e3 to f586ec98d924 (1 revision) (flutter/engine#43908) 2023-07-21 [email protected] Roll Fuchsia Mac SDK from WH3AaCa4DtVERww1v... to rMFZIJYvVmXEBGCay... (flutter/engine#43907) 2023-07-21 [email protected] [Impeller] Do not use clear color optimization if the subpass is being collapsed into its parent (flutter/engine#43878) 2023-07-21 [email protected] Roll Skia from 2e28fe9de378 to 359d4726e423 (1 revision) (flutter/engine#43906) 2023-07-21 [email protected] [Impeller] Disable color attachment removal for clips on VK (flutter/engine#43905) 2023-07-21 [email protected] [Impeller] Add a way to query the gfx backend type. (flutter/engine#43837) 2023-07-21 [email protected] Roll ANGLE from 82d68c577b1d to 085f25bbb1e3 (1 revision) (flutter/engine#43904) 2023-07-21 [email protected] Roll ANGLE from 2e190280f5c5 to 82d68c577b1d (1 revision) (flutter/engine#43901) 2023-07-21 [email protected] Roll Skia from 497326dc66cd to 2e28fe9de378 (2 revisions) (flutter/engine#43900) 2023-07-21 [email protected] Roll Skia from 1f84e9d51bba to 497326dc66cd (1 revision) (flutter/engine#43899) Also rolling transitive DEPS: fuchsia/sdk/core/mac-amd64 from WH3AaCa4DtVE to rMFZIJYvVmXE If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
vashworth
pushed a commit
to vashworth/flutter
that referenced
this pull request
Aug 2, 2023
…lutter#131101) flutter/engine@2d8cff4...840bcc3 2023-07-21 [email protected] Roll ANGLE from f586ec98d924 to 938ee1e80fc8 (1 revision) (flutter/engine#43912) 2023-07-21 [email protected] Roll ANGLE from 085f25bbb1e3 to f586ec98d924 (1 revision) (flutter/engine#43908) 2023-07-21 [email protected] Roll Fuchsia Mac SDK from WH3AaCa4DtVERww1v... to rMFZIJYvVmXEBGCay... (flutter/engine#43907) 2023-07-21 [email protected] [Impeller] Do not use clear color optimization if the subpass is being collapsed into its parent (flutter/engine#43878) 2023-07-21 [email protected] Roll Skia from 2e28fe9de378 to 359d4726e423 (1 revision) (flutter/engine#43906) 2023-07-21 [email protected] [Impeller] Disable color attachment removal for clips on VK (flutter/engine#43905) 2023-07-21 [email protected] [Impeller] Add a way to query the gfx backend type. (flutter/engine#43837) 2023-07-21 [email protected] Roll ANGLE from 82d68c577b1d to 085f25bbb1e3 (1 revision) (flutter/engine#43904) 2023-07-21 [email protected] Roll ANGLE from 2e190280f5c5 to 82d68c577b1d (1 revision) (flutter/engine#43901) 2023-07-21 [email protected] Roll Skia from 497326dc66cd to 2e28fe9de378 (2 revisions) (flutter/engine#43900) 2023-07-21 [email protected] Roll Skia from 1f84e9d51bba to 497326dc66cd (1 revision) (flutter/engine#43899) Also rolling transitive DEPS: fuchsia/sdk/core/mac-amd64 from WH3AaCa4DtVE to rMFZIJYvVmXE If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The InlinePassContext will not apply the clear color within a parent pass that is already in progress.
Fixes flutter/flutter#130824