This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Revert "Fix global tests doing nothing." #45125
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 52e8f5f.
bdero
approved these changes
Aug 25, 2023
zanderso
added
warning: land on red to fix tree breakage
godofredoc
approved these changes
Aug 25, 2023
|
@godofredoc Looks like it's trying to run an engine built for the arm64 simulator on an intel machine? |
Yeah I'll probably reland only the mac_ios portion and wait for a fix to flutter/flutter#133306 before relanding mac_unopt and mac_host_engine. |
|
Landing eagerly to re-open the tree. Only the web and fuchsia tests are still running, but they can't be affected by this change. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 25, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 25, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Aug 25, 2023
…133355) flutter/engine@1471967...1ec7b89 2023-08-25 [email protected] Remove --enable-software-rendering from iOS scenario tests (flutter/engine#45093) 2023-08-25 [email protected] Roll Skia from 56bb647a49ac to 76672468e8d7 (3 revisions) (flutter/engine#45121) 2023-08-25 [email protected] Fix: Complete Documentation for RasterStatus::kSkipAndRetry (flutter/engine#44880) 2023-08-25 [email protected] [Impeller] Updated TextureSourceVK docs and deleted unused ivars (flutter/engine#45123) 2023-08-25 [email protected] Revert "Fix global tests doing nothing." (flutter/engine#45125) 2023-08-25 [email protected] Roll Skia from ba7c5258d2b4 to 56bb647a49ac (3 revisions) (flutter/engine#45118) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
gaaclarke
pushed a commit
to gaaclarke/engine
that referenced
this pull request
Aug 30, 2023
Reverts flutter#45097 Many failures on CI like: ``` ld: warning: ignoring file ../../../../out/ios_debug_sim_arm64_extension_safe/libocmock_shared.dylib, building for iOS Simulator-x86_64 but attempting to link with file built for iOS Simulator-arm64 ld: warning: ignoring file ../../../../out/ios_debug_sim_arm64_extension_safe/libios_test_flutter.dylib, building for iOS Simulator-x86_64 but attempting to link with file built for iOS Simulator-arm64 ``` https://ci.chromium.org/ui/p/flutter/builders/prod/Mac%20Production%20Engine%20Drone/131188/overview Not sure if there are also other tests failing in different ways.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #45097
Many failures on CI like:
https://ci.chromium.org/ui/p/flutter/builders/prod/Mac%20Production%20Engine%20Drone/131188/overview
Not sure if there are also other tests failing in different ways.