This repository was archived by the owner on Feb 25, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6k
Adds an --rbe option to tools/gn that works on Linux hosts #45271
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -47,6 +47,10 @@ vars = { | |
# https://chrome-infra-packages.appspot.com/p/fuchsia/third_party/goma/client | ||
'goma_version': ' git_revision:41b3bcb64014144a844153fd5588c36411fffb56', | ||
|
||
'reclient_version': 'git_revision:81e819b39d4743462857cc55430d898b9fcca1af', | ||
|
||
'gcloud_version': 'version:[email protected]', | ||
|
||
# When updating the Dart revision, ensure that all entries that are | ||
# dependencies of Dart are also updated to match the entries in the | ||
# Dart SDK's DEPS file for that revision of Dart. The DEPS file for | ||
|
@@ -880,6 +884,30 @@ deps = { | |
'dep_type': 'cipd', | ||
}, | ||
|
||
# reclient. | ||
'src/buildtools/linux-x64/reclient': { | ||
'packages': [ | ||
{ | ||
'package': 'infra/rbe/client/${{platform}}', | ||
'version': Var('reclient_version'), | ||
} | ||
], | ||
'condition': 'host_os == "linux" and host_cpu == "x64"', | ||
'dep_type': 'cipd', | ||
}, | ||
|
||
# gcloud | ||
'src/buildtools/linux-x64/gcloud': { | ||
'packages': [ | ||
{ | ||
'package': 'infra/3pp/tools/gcloud/${{platform}}', | ||
'version': Var('gcloud_version'), | ||
} | ||
], | ||
'condition': 'host_os == "linux" and host_cpu == "x64"', | ||
'dep_type': 'cipd', | ||
}, | ||
|
||
# Get the SDK from https://chrome-infra-packages.appspot.com/p/fuchsia/sdk/core at the 'latest' tag | ||
# Get the toolchain from https://chrome-infra-packages.appspot.com/p/fuchsia/clang at the 'goma' tag | ||
'src/fuchsia/sdk/mac': { | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From LUCI side, we expect to have a cleanup/shutdown step after task finishes. You may want to mention somewhere that users are expected to cleanup/shutdown the bootstrap later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There isn't a good spot to put that in the local dev workflow, and the command is too long to ask folks to run by hand, so that will need some more thought.