Multi-view pointer event #46213

dkwingsmt · 2023-09-22T21:10:57Z

This PR adds a new field view_id to embedder API's FlutterPointerEvent, allowing platforms to specify the source view of pointer events.

flutter/flutter#112205

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
I listed at least one issue that this PR fixes in the description above.
I added new tests to check the change I am making or feature I am adding, or the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
I updated/added relevant documentation (doc comments with ///).
I signed the CLA.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

loic-sharma

Please don't merge this yet as the embedder API isn't approved yet: flutter.dev/go/multi-view-embedder-apis

(Feel free to reset my vote later when the design does receive approval)

lib/ui/window/pointer_data_packet_converter_unittests.cc

shell/platform/android/io/flutter/embedding/android/AndroidTouchProcessor.java

shell/platform/windows/flutter_windows_view.cc

shell/platform/embedder/embedder.h

flutter-dashboard · 2023-11-29T23:05:34Z

This pull request executed golden file tests, but it has not been updated in a while (20+ days). Test results from Gold expire after as many days, so this pull request will need to be updated with a fresh commit in order to get results from Gold.

shell/platform/darwin/ios/framework/Source/FlutterViewController.mm

lib/ui/window/pointer_data_packet_converter_unittests.cc

shell/platform/android/io/flutter/embedding/android/AndroidTouchProcessor.java

lib/ui/platform_dispatcher.dart

lib/ui/window/pointer_data.cc

lib/ui/window/pointer_data.h

loic-sharma

Engine, embedder API, and desktop embedder changes look good to me!

Please consider another review for Android and iOS changes.

Co-authored-by: Loïc Sharma <[email protected]>

…140519) Roll Flutter Engine from c70f0a495ace to 1b1b2a12a597 (32 revisions) flutter/engine@c70f0a4...1b1b2a1 2023-12-21 [email protected] Roll Dart SDK from 4a10533a4dc8 to bcf68d22f0fa (1 revision) (flutter/engine#49329) 2023-12-21 [email protected] Roll Dart SDK from 1d0c3ecd1349 to 4a10533a4dc8 (1 revision) (flutter/engine#49326) 2023-12-21 [email protected] Ensure sorted rects in ui.Canvas for legacy compatibility (flutter/engine#49309) 2023-12-21 [email protected] Roll Dart SDK from 63a452b45026 to 1d0c3ecd1349 (1 revision) (flutter/engine#49318) 2023-12-21 [email protected] [Impeller] Make IPLR files multi-platform (flutter/engine#49253) 2023-12-21 [email protected] [web] Defer injection of platform views until needed. (flutter/engine#48960) 2023-12-21 [email protected] Roll Dart SDK from 1aef027ec953 to 63a452b45026 (2 revisions) (flutter/engine#49311) 2023-12-21 [email protected] Roll Skia from 29917d8c97ca to 4b16117e94b2 (4 revisions) (flutter/engine#49310) 2023-12-21 [email protected] Reland "[Windows] Move to FlutterCompositor for rendering" (flutter/engine#49262) 2023-12-21 [email protected] Reland `[Impeller] new blur: refactored math and fixed expanded padding size` (flutter/engine#49302) 2023-12-20 [email protected] Multiview pipeline Pt. 1: Skip illegal render calls (flutter/engine#49266) 2023-12-20 [email protected] SemanticsUpdateBuilder: make all args non-null (flutter/engine#49148) 2023-12-20 [email protected] [Impeller] fixed Rect::Contains (flutter/engine#49294) 2023-12-20 [email protected] Roll Dart SDK from 97c3b7e1885a to 1aef027ec953 (1 revision) (flutter/engine#49295) 2023-12-20 [email protected] Revert "[Impeller] new blur: refactored math and fixed expanded padding size" (flutter/engine#49298) 2023-12-20 [email protected] [Impeller] new blur: refactored math and fixed expanded padding size (flutter/engine#49206) 2023-12-20 [email protected] Multi-view pointer event (flutter/engine#46213) 2023-12-20 [email protected] [web:multiview] Only call `Renderer.clearFragmentProgramCache` on hot restart (flutter/engine#48758) 2023-12-20 [email protected] Roll Skia from 9cb1bb1164ea to 29917d8c97ca (1 revision) (flutter/engine#49289) 2023-12-20 [email protected] [Impeller] Add interactive Blur+Clip AiksTest. (flutter/engine#49283) 2023-12-20 [email protected] [macos] FlutterKeyboardManager memory leak fix (flutter/engine#48824) 2023-12-20 [email protected] Don't guard Windows arm64 Dart SDK download on the release candidate flag (flutter/engine#49244) 2023-12-20 [email protected] Fix testAppExtensionLaunching for Xcode 15/iOS 17 (flutter/engine#49242) 2023-12-20 [email protected] Roll Skia from 8060d6b36066 to 9cb1bb1164ea (2 revisions) (flutter/engine#49288) 2023-12-20 [email protected] Roll Dart SDK from ed415d966d8a to 97c3b7e1885a (1 revision) (flutter/engine#49287) 2023-12-20 [email protected] Roll Skia from d0f09ad481f7 to 8060d6b36066 (1 revision) (flutter/engine#49285) 2023-12-20 [email protected] [release] Update release config (flutter/engine#49254) 2023-12-20 [email protected] Roll Dart SDK from 1732c4c92ccd to ed415d966d8a (1 revision) (flutter/engine#49274) 2023-12-20 [email protected] Roll Dart SDK from 4c59838945d9 to 1732c4c92ccd (1 revision) (flutter/engine#49269) 2023-12-20 [email protected] Sync lints with flutter/flutter (flutter/engine#49192) 2023-12-19 [email protected] [web] Enforce onDrawFrame/onBeginFrame render rule (flutter/engine#49214) 2023-12-19 [email protected] [Docs] Add more info about running tests on iOS (flutter/engine#48859) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md ...

…lutter#140519) Roll Flutter Engine from c70f0a495ace to 1b1b2a12a597 (32 revisions) flutter/engine@c70f0a4...1b1b2a1 2023-12-21 [email protected] Roll Dart SDK from 4a10533a4dc8 to bcf68d22f0fa (1 revision) (flutter/engine#49329) 2023-12-21 [email protected] Roll Dart SDK from 1d0c3ecd1349 to 4a10533a4dc8 (1 revision) (flutter/engine#49326) 2023-12-21 [email protected] Ensure sorted rects in ui.Canvas for legacy compatibility (flutter/engine#49309) 2023-12-21 [email protected] Roll Dart SDK from 63a452b45026 to 1d0c3ecd1349 (1 revision) (flutter/engine#49318) 2023-12-21 [email protected] [Impeller] Make IPLR files multi-platform (flutter/engine#49253) 2023-12-21 [email protected] [web] Defer injection of platform views until needed. (flutter/engine#48960) 2023-12-21 [email protected] Roll Dart SDK from 1aef027ec953 to 63a452b45026 (2 revisions) (flutter/engine#49311) 2023-12-21 [email protected] Roll Skia from 29917d8c97ca to 4b16117e94b2 (4 revisions) (flutter/engine#49310) 2023-12-21 [email protected] Reland "[Windows] Move to FlutterCompositor for rendering" (flutter/engine#49262) 2023-12-21 [email protected] Reland `[Impeller] new blur: refactored math and fixed expanded padding size` (flutter/engine#49302) 2023-12-20 [email protected] Multiview pipeline Pt. 1: Skip illegal render calls (flutter/engine#49266) 2023-12-20 [email protected] SemanticsUpdateBuilder: make all args non-null (flutter/engine#49148) 2023-12-20 [email protected] [Impeller] fixed Rect::Contains (flutter/engine#49294) 2023-12-20 [email protected] Roll Dart SDK from 97c3b7e1885a to 1aef027ec953 (1 revision) (flutter/engine#49295) 2023-12-20 [email protected] Revert "[Impeller] new blur: refactored math and fixed expanded padding size" (flutter/engine#49298) 2023-12-20 [email protected] [Impeller] new blur: refactored math and fixed expanded padding size (flutter/engine#49206) 2023-12-20 [email protected] Multi-view pointer event (flutter/engine#46213) 2023-12-20 [email protected] [web:multiview] Only call `Renderer.clearFragmentProgramCache` on hot restart (flutter/engine#48758) 2023-12-20 [email protected] Roll Skia from 9cb1bb1164ea to 29917d8c97ca (1 revision) (flutter/engine#49289) 2023-12-20 [email protected] [Impeller] Add interactive Blur+Clip AiksTest. (flutter/engine#49283) 2023-12-20 [email protected] [macos] FlutterKeyboardManager memory leak fix (flutter/engine#48824) 2023-12-20 [email protected] Don't guard Windows arm64 Dart SDK download on the release candidate flag (flutter/engine#49244) 2023-12-20 [email protected] Fix testAppExtensionLaunching for Xcode 15/iOS 17 (flutter/engine#49242) 2023-12-20 [email protected] Roll Skia from 8060d6b36066 to 9cb1bb1164ea (2 revisions) (flutter/engine#49288) 2023-12-20 [email protected] Roll Dart SDK from ed415d966d8a to 97c3b7e1885a (1 revision) (flutter/engine#49287) 2023-12-20 [email protected] Roll Skia from d0f09ad481f7 to 8060d6b36066 (1 revision) (flutter/engine#49285) 2023-12-20 [email protected] [release] Update release config (flutter/engine#49254) 2023-12-20 [email protected] Roll Dart SDK from 1732c4c92ccd to ed415d966d8a (1 revision) (flutter/engine#49274) 2023-12-20 [email protected] Roll Dart SDK from 4c59838945d9 to 1732c4c92ccd (1 revision) (flutter/engine#49269) 2023-12-20 [email protected] Sync lints with flutter/flutter (flutter/engine#49192) 2023-12-19 [email protected] [web] Enforce onDrawFrame/onBeginFrame render rule (flutter/engine#49214) 2023-12-19 [email protected] [Docs] Add more info about running tests on iOS (flutter/engine#48859) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md ...

Impl

449ba20

github-actions bot added platform-ios platform-android platform-web Code specifically for the web engine affects: desktop platform-macos platform-linux platform-windows labels Sep 22, 2023

dkwingsmt added 10 commits September 22, 2023 16:07

Add constants

14b4308

fix compile

e9e363b

Fix event not sending view id

cf6baa9

Merge remote-tracking branch 'origin/main' into mv-pointer-event

bcd355f

Merge remote-tracking branch 'origin/main' into mv-pointer-event

d2deb5a

Fix doc

5458a05

Doc and comment

7464bb9

More comment

91edc9b

Add view ID for all pointer events in Win

307ec40

Better TODO for iOS

7603a36

dkwingsmt marked this pull request as ready for review November 9, 2023 22:29

dkwingsmt requested review from cbracken and chinmaygarde as code owners November 9, 2023 22:29

Compile

fe1cc52

This comment was marked as duplicate.

Sign in to view

loic-sharma suggested changes Nov 9, 2023

View reviewed changes

loic-sharma reviewed Nov 9, 2023

View reviewed changes

lib/ui/window/pointer_data_packet_converter_unittests.cc Outdated Show resolved Hide resolved

loic-sharma reviewed Nov 9, 2023

View reviewed changes

shell/platform/android/io/flutter/embedding/android/AndroidTouchProcessor.java Outdated Show resolved Hide resolved

loic-sharma reviewed Nov 9, 2023

View reviewed changes

shell/platform/windows/flutter_windows_view.cc Outdated Show resolved Hide resolved

loic-sharma reviewed Nov 9, 2023

View reviewed changes

shell/platform/embedder/embedder.h Outdated Show resolved Hide resolved

Merge remote-tracking branch 'origin/main' into mv-pointer-event

7359346

loic-sharma reviewed Dec 12, 2023

View reviewed changes

shell/platform/darwin/ios/framework/Source/FlutterViewController.mm Outdated Show resolved Hide resolved

loic-sharma reviewed Dec 12, 2023

View reviewed changes

lib/ui/window/pointer_data_packet_converter_unittests.cc Show resolved Hide resolved

loic-sharma reviewed Dec 12, 2023

View reviewed changes

shell/platform/android/io/flutter/embedding/android/AndroidTouchProcessor.java Outdated Show resolved Hide resolved

loic-sharma reviewed Dec 12, 2023

View reviewed changes

lib/ui/platform_dispatcher.dart Outdated Show resolved Hide resolved

Better id doc

3002924

loic-sharma self-requested a review December 12, 2023 22:22

dkwingsmt added 2 commits December 13, 2023 01:08

Fix viewIdentifier

e46154d

mirrored var

47fc6a0

loic-sharma reviewed Dec 13, 2023

View reviewed changes

lib/ui/platform_dispatcher.dart Outdated Show resolved Hide resolved

loic-sharma reviewed Dec 13, 2023

View reviewed changes

lib/ui/window/pointer_data.cc Show resolved Hide resolved

dkwingsmt added 3 commits December 13, 2023 14:25

Fix doc

7e838af

Add test for packing view ID

bd1cfdb

default to implicit

456cebe

loic-sharma reviewed Dec 19, 2023

View reviewed changes

lib/ui/window/pointer_data.h Outdated Show resolved Hide resolved

loic-sharma approved these changes Dec 19, 2023

View reviewed changes

Update lib/ui/window/pointer_data.h

713672b

Co-authored-by: Loïc Sharma <[email protected]>

dkwingsmt mentioned this pull request Dec 19, 2023

Multi-view View Metrics #46174

Merged

8 tasks

Merge branch 'main' into mv-pointer-event

1f3f96a

chinmaygarde approved these changes Dec 20, 2023

View reviewed changes

dkwingsmt added the autosubmit Merge PR when tree becomes green via auto submit App label Dec 20, 2023

auto-submit bot merged commit b24076e into flutter:main Dec 20, 2023

engine-flutter-autoroll mentioned this pull request Dec 21, 2023

Roll Flutter Engine from c70f0a495ace to 1b1b2a12a597 (32 revisions) flutter/flutter#140519

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 21, 2023

b24076e4e Multi-view pointer event (flutter/engine#46213)

d2a61db

loic-sharma mentioned this pull request Mar 12, 2024

☂️ Multi View for Windows/MacOS flutter/flutter#142845

Open

55 tasks

loic-sharma mentioned this pull request Apr 5, 2024

Add new multi-view embedder APIs flutter/flutter#144806

Open

9 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Multi-view pointer event #46213

Multi-view pointer event #46213

Uh oh!

dkwingsmt commented Sep 22, 2023 •

edited

Loading

Uh oh!

This comment was marked as duplicate.

Uh oh!

loic-sharma left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

flutter-dashboard bot commented Nov 29, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

loic-sharma left a comment

Uh oh!

Uh oh!

Multi-view pointer event #46213

Multi-view pointer event #46213

Uh oh!

Conversation

dkwingsmt commented Sep 22, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

Uh oh!

This comment was marked as duplicate.

Uh oh!

loic-sharma left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

flutter-dashboard bot commented Nov 29, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

loic-sharma left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

dkwingsmt commented Sep 22, 2023 •

edited

Loading