This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Remove obsolete tests that were time sensitive. #46686
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These were always filtered away. On Fuchsia, where the filters were not in place, there was an ifdef guard.
zanderso
approved these changes
Oct 9, 2023
Co-authored-by: Zachary Anderson <[email protected]>
chinmaygarde
added
the
autosubmit
auto-submit
bot
removed
the
autosubmit
|
auto label is removed for flutter/engine/46686, due to - The status or check suite Linux linux_license has failed. Please fix the issues identified (or deflake) before re-applying this label. |
chinmaygarde
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 9, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 9, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Oct 9, 2023
…136228) flutter/engine@8f2fa3c...51193f8 2023-10-09 [email protected] Roll Dart SDK from a6e43b0b9e0c to 078162ecf493 (1 revision) (flutter/engine#46691) 2023-10-09 [email protected] Roll Skia from e56387226035 to f45ac4569300 (1 revision) (flutter/engine#46690) 2023-10-09 [email protected] Remove obsolete tests that were time sensitive. (flutter/engine#46686) 2023-10-09 [email protected] Roll Skia from bd77f099b4f9 to e56387226035 (1 revision) (flutter/engine#46687) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Mairramer
pushed a commit
to Mairramer/flutter
that referenced
this pull request
Oct 10, 2023
…lutter#136228) flutter/engine@8f2fa3c...51193f8 2023-10-09 [email protected] Roll Dart SDK from a6e43b0b9e0c to 078162ecf493 (1 revision) (flutter/engine#46691) 2023-10-09 [email protected] Roll Skia from e56387226035 to f45ac4569300 (1 revision) (flutter/engine#46690) 2023-10-09 [email protected] Remove obsolete tests that were time sensitive. (flutter/engine#46686) 2023-10-09 [email protected] Roll Skia from bd77f099b4f9 to e56387226035 (1 revision) (flutter/engine#46687) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
harryterkelsen
pushed a commit
that referenced
this pull request
Oct 23, 2023
These were always filtered away. On Fuchsia, where the filters were not in place, there was an ifdef guard. Followup to flutter/flutter#80457 (comment) --------- Co-authored-by: Zachary Anderson <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These were always filtered away. On Fuchsia, where the filters were not in place, there was an ifdef guard.
Followup to flutter/flutter#80457 (comment)