This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Reland: [web] Ensure handled key event is not propagated to IME #47099
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knopp
force-pushed
the
reland_136460_web_no_propagate_handled_event_to_ime
branch
from
a7879a1 to
57b0044
Compare
dkwingsmt
approved these changes
Nov 3, 2023
knopp
force-pushed
the
reland_136460_web_no_propagate_handled_event_to_ime
branch
from
57b0044 to
8bce406
Compare
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 3, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Nov 3, 2023
…137845) flutter/engine@43653c5...8531c59 2023-11-03 [email protected] Reland: [web] Ensure handled key event is not propagated to IME (flutter/engine#47099) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR relands #46829, which got reverted in #47086 because of flutter/flutter#136857.
There are no changes in the PR compared to the reverted one. The issue are missing
keyupevents in the integration test, which triggers assertion inKeyboardBindingsand which should be fixed by flutter/flutter#136874.Changes:
RawKeyboardevent handler is invoked fromKeyboardBindingevent handler. This is to prevent race condition because both handlers now run in capture phase andKeyboardBindingneeds to process the event first.Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.