Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Change FTL test to high capacity device #47579

Merged
merged 1 commit into from
Nov 2, 2023

Conversation

gmackall
Copy link
Member

@gmackall gmackall commented Nov 1, 2023

Changes the FTL tests to use a high capacity device

Similar PR from packages repo: flutter/packages#5224

The list of devices (and their capacity) is visible through the 3rd option here "Google APIs Explorer", without a login to any project.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@gmackall gmackall marked this pull request as ready for review November 1, 2023 23:44
Copy link
Contributor

@ricardoamador ricardoamador left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@gmackall gmackall added autosubmit Merge PR when tree becomes green via auto submit App warning: land on red to fix tree breakage Override tree-status signal (land even with closed tree), combine with the autosubmit label. labels Nov 2, 2023
@auto-submit auto-submit bot merged commit eec2ae4 into flutter:main Nov 2, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 2, 2023
fluttermirroringbot pushed a commit to flutter/flutter that referenced this pull request Nov 2, 2023
…137740)

flutter/engine@406f0c4...eec2ae4

2023-11-02 [email protected] Change FTL test to high capacity device (flutter/engine#47579)
2023-11-01 [email protected] Roll Skia from 613abdf2c895 to 945284d57785 (1 revision) (flutter/engine#47564)
2023-11-01 [email protected] Bump impeller-cmake to head (flutter/engine#47563)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
autosubmit Merge PR when tree becomes green via auto submit App warning: land on red to fix tree breakage Override tree-status signal (land even with closed tree), combine with the autosubmit label.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants