Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[PlatformView][Android]VirtualDisplay resize on Android31 and above #47946

Merged
merged 16 commits into from
Nov 21, 2023
Merged

[PlatformView][Android]VirtualDisplay resize on Android31 and above #47946

Changes from all commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
75d1fe7
[PlatformView][Android]VirtualDisplay resize on Android31 and above(#…
designDo Nov 11, 2023
d1c12da
add import
designDo Nov 11, 2023
7a1c649
Code format
designDo Nov 11, 2023
950afdd
Code format
designDo Nov 11, 2023
228be10
Code format
designDo Nov 11, 2023
afe1b13
add TargetAPI 21
designDo Nov 13, 2023
ccda5a7
Merge branch 'main' into pre/128920
designDo Nov 13, 2023
5e10d6e
Merge branch 'main' into pre/128920
designDo Nov 15, 2023
f29bcf9
Merge branch 'main' into pre/128920
designDo Nov 15, 2023
f5abcd3
Fixed review code
designDo Nov 15, 2023
f6c61ee
Merge branch 'main' into pre/128920
designDo Nov 15, 2023
5391593
Merge branch 'main' into pre/128920
designDo Nov 16, 2023
ba38dca
Merge branch 'main' into pre/128920
designDo Nov 17, 2023
f000fe0
remove meaningless comments and add add onNewSizeFrameAvailable call…
designDo Nov 17, 2023
8b2f684
Merge branch 'main' into pre/128920
designDo Nov 21, 2023
502bab9
remove meaningless comments
designDo Nov 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions shell/platform/android/io/flutter/plugin/platform/VirtualDisplayController.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
import android.content.Context;
import android.hardware.display.DisplayManager;
import android.hardware.display.VirtualDisplay;
import android.os.Build;
import android.util.DisplayMetrics;
import android.view.MotionEvent;
import android.view.View;
Expand Down Expand Up @@ -128,6 +129,16 @@ public int getRenderTargetHeight() {
}

public void resize(final int width, final int height, final Runnable onNewSizeFrameAvailable) {
// When 'hot reload', although the resize method is triggered, the size of the native View has
// not changed.
if (width == getRenderTargetWidth() && height == getRenderTargetHeight()) {
getView().postDelayed(onNewSizeFrameAvailable, 0);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the contract around onNewSizeFrameAvailable? In the case that the size doesn't change do we need to run it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, postDelayed can be removed

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is true, it must be called.

return;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After reading the calling code, we do need to run the onNewSizeFrameAvailable in this case.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Meaningless comments have been removed.
In this case, added onNewSizeFrameAvailable callback.
Thank you for your guidance and help!

}
if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.S) {
resize31(getView(), width, height, onNewSizeFrameAvailable);
return;
}
boolean isFocused = getView().isFocused();
final SingleViewPresentation.PresentationState presentationState = presentation.detachState();
// We detach the surface to prevent it being destroyed when releasing the vd.
Expand Down Expand Up @@ -199,6 +210,15 @@ public void dispose() {
renderTarget.release();
}

@TargetApi(31)
private void resize31(
View embeddedView, int width, int height, final Runnable onNewSizeFrameAvailable) {
renderTarget.resize(width, height);
// On Android versions 31+ resizing of a Virtual Display's Presentation is natively supported.
virtualDisplay.resize(width, height, densityDpi);
embeddedView.postDelayed(onNewSizeFrameAvailable, 0);
}

/** See {@link PlatformView#onFlutterViewAttached(View)} */
/*package*/ void onFlutterViewAttached(@NonNull View flutterView) {
if (presentation == null || presentation.getView() == null) {
Expand Down