Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Make fml/status_or.h compatible with .clang_tidy. #48002

Merged
merged 6 commits into from
Nov 16, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 15 additions & 4 deletions fml/status_or.h
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,12 @@ namespace fml {
template <typename T>
class StatusOr {
public:
// These constructors are intended be compatible with absl::status_or.
// NOLINTNEXTLINE(google-explicit-constructor)
StatusOr(const T& value) : status_(), value_(value) {}

// These constructors are intended be compatible with absl::status_or.
// NOLINTNEXTLINE(google-explicit-constructor)
StatusOr(const Status& status) : status_(status), value_() {}

StatusOr(const StatusOr&) = default;
Expand Down Expand Up @@ -63,13 +68,19 @@ class StatusOr {
bool ok() const { return status_.ok(); }

const T& value() const {
FML_CHECK(status_.ok());
return value_.value();
if (status_.ok()) {
return value_.value();
}
FML_LOG(FATAL) << "StatusOr::value() called on error Status";
FML_UNREACHABLE();
}

T& value() {
FML_CHECK(status_.ok());
return value_.value();
if (status_.ok()) {
return value_.value();
}
FML_LOG(FATAL) << "StatusOr::value() called on error Status";
FML_UNREACHABLE();
}

private:
Expand Down