Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Re-land "Make lib/ui/{text|window}/... compatible with .ci.yaml" #48097

Merged

Conversation

matanlurey
Copy link
Contributor

Reverts #48083.

@matanlurey matanlurey added the test: all See https://github.com/flutter/engine/blob/main/docs/ci/Engine-pre-submits-and-post-submits.md label Nov 15, 2023
@matanlurey matanlurey force-pushed the revert-48083-revert_ee590d48afa19b106775c6ee68e99f58760c2637 branch from b518b6a to 8c73e21 Compare November 16, 2023 00:27
@matanlurey matanlurey marked this pull request as ready for review November 16, 2023 02:41
Copy link
Member

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stuartmorgan-g
Copy link
Contributor

test-exempt: helps unblock turning on a check that will automatically enforce the change

@matanlurey matanlurey merged commit 380578a into main Nov 16, 2023
@matanlurey matanlurey deleted the revert-48083-revert_ee590d48afa19b106775c6ee68e99f58760c2637 branch November 16, 2023 16:40
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 16, 2023
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Nov 16, 2023
…138560)

flutter/engine@0c57a50...22baa83

2023-11-16 [email protected] Make `lib/ui/painting/...` compatible with `.clang_tidy`. (flutter/engine#47999)
2023-11-16 [email protected] Re-land "Make `lib/ui/{text|window}/...` compatible with `.ci.yaml`" (flutter/engine#48097)
2023-11-16 [email protected] Roll Skia from bf1d6d84db73 to b9ead4140f84 (1 revision) (flutter/engine#48124)
2023-11-16 [email protected] Roll Skia from 2fe70dd9cbf8 to bf1d6d84db73 (1 revision) (flutter/engine#48122)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
test: all See https://github.com/flutter/engine/blob/main/docs/ci/Engine-pre-submits-and-post-submits.md
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants