Try rolling a new version of googletest (2021->2023).

[matanlurey]

No description provided.

[zanderso]

Looks like some updates to https://github.com/flutter/engine/blob/main/build/secondary/third_party/googletest/BUILD.gn are needed.

[matanlurey]

Looks like some updates to https://github.com/flutter/engine/blob/main/build/secondary/third_party/googletest/BUILD.gn are needed.

Right, there is actually a simplified source setup now:

# Only add the "*-all.cc" files (and no headers) to improve maintainability
# from upstream refactoring. The "*-all.cc" files include the respective
# source files.
sources = [ "googletest/src/gtest-all.cc" ]

Running on CI to see how it feels :)

[matanlurey]

Looks like this will pass, with the exception of some breakages in Fuchsia I'm not sure how to resolve:

../../third_party/googletest/googlemock/include/gmock/gmock-matchers.h:4416:36: note: in instantiation of function template specialization 'testing::MatcherCast<const fuchsia::math::SizeU &, fuchsia::math::SizeU>' requested here
 4416 |           property_name, property, MatcherCast<const PropertyType&>(matcher)));
      |                                    ^
../../flutter/shell/platform/fuchsia/flutter/tests/external_view_embedder_unittests.cc:189:7: note: in instantiation of function template specialization 'testing::Property<fuchsia::ui::composition::ImageProperties, const fuchsia::math::SizeU &, fuchsia::math::SizeU>' requested here
  189 |       Property("size", &fuchsia::ui::composition::ImageProperties::size, size));
      |       ^

It might just mean gmock's secondary build needs an update too.