binary_messenger missing cstdint

[jwinarske]

This PR adds cstdint to binary_messenger.h. Without this building plugin support for generic Linux fails. Not related to the GTK source tree.

Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.

List which issues are fixed by this PR. You must list at least one issue.

If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.

Pre-launch Checklist

• I read the Contributor Guide and followed the process outlined there for submitting PRs.
• I read the Tree Hygiene wiki page, which explains my responsibilities.
• I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
• I listed at least one issue that this PR fixes in the description above.
• I added new tests to check the change I am making or feature I am adding, or the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
• I updated/added relevant documentation (doc comments with ///).
• I signed the CLA.
• All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

[flutter-dashboard]

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie or stuartmorgan on the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

[bdero]

LGTM

[bdero]

Huh, it looks like we had the big clang-tidy switcheroo yesterday: #48145

FYI @matanlurey, I thought there was a clang tidy lint to enforce direct stl includes, but searching around the list I'm not locating one...

[matanlurey]

the list

No, we have no such thing. See flutter/flutter#133417, I'd love help doing this :)

[matanlurey]

I'm reverting this PR as we didn't agree to land it (see Discord thread).

[jwinarske]

grep in main (pre-PR):

common/client_wrapper/include/flutter/texture_registrar.h:#include <cstdint>
common/client_wrapper/include/flutter/encodable_value.h:#include <cstdint>
common/client_wrapper/byte_buffer_streams.h:#include <cstdint>

[jwinarske]

Originating error:

In file included from /home/joel/test/example/plugins/pigeon/messages.g.cc:9:
In file included from /home/joel/test/example/plugins/pigeon/messages.g.h:9:
In file included from /home/joel/test/third_party/flutter/shell/platform/common/client_wrapper/include/flutter/basic_message_channel.h:12:
/home/joel/test/third_party/flutter/shell/platform/common/client_wrapper/include/flutter/binary_messenger.h:16:34: error: unknown type name 'uint8_t'
typedef std::function<void(const uint8_t* reply, size_t reply_size)>
                                 ^

[jwinarske]

@stuartmorgan What is your actionable feedback for me on this?

Does it need a test case, if so where in the tree should I locate it?