Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[web] Bootstrap tests without implicit view by default #48629

Merged
merged 9 commits into from
Jan 22, 2024
Merged

[web] Bootstrap tests without implicit view by default #48629

merged 9 commits into from
Jan 22, 2024

Conversation

mdebbar
Copy link
Contributor

@mdebbar mdebbar commented Dec 4, 2023

  • Follow up tests for [web] No implicit view in multi-view mode #48505
    • Tests for navigation without an implicit view should work.
  • Package this workaround behind a nice, future-proof API.
  • Tests by default start with no implicit view.
    • Tests that need an implicit view have to explicitly indicate so (by using the withImplicitView param).

Fixes flutter/flutter#138906

@github-actions github-actions bot added the platform-web Code specifically for the web engine label Dec 4, 2023
@flutter-dashboard
Copy link

Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change).

If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review.

Changes reported for pull request #48629 at sha cc63cac

@flutter-dashboard
Copy link

Golden file changes are available for triage from new commit, Click here to view.

Changes reported for pull request #48629 at sha 6192ea2

@flutter-dashboard
Copy link

Golden file changes are available for triage from new commit, Click here to view.

Changes reported for pull request #48629 at sha 48c41c3

@flutter-dashboard
Copy link

Golden file changes are available for triage from new commit, Click here to view.

Changes reported for pull request #48629 at sha 5faf562

@mdebbar
Copy link
Contributor Author

mdebbar commented Jan 18, 2024

The golden changes are all minor anti-aliasing differences. I approved them.

@mdebbar mdebbar requested review from ditman and yjbanov January 18, 2024 21:54
yjbanov
yjbanov approved these changes Jan 18, 2024
View reviewed changes
Copy link
Contributor

@yjbanov yjbanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

lib/web_ui/test/engine/semantics/semantics_multi_view_test.dart
await bootstrapAndRunApp();
final EngineFlutterWindow implicitView = EnginePlatformDispatcher.instance.implicitView!;
EnginePlatformDispatcher.instance.viewManager.disposeAndUnregisterView(implicitView.viewId);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😍

@mdebbar mdebbar added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 22, 2024
@flutter-dashboard
Copy link

Golden file changes are available for triage from new commit, Click here to view.

Changes reported for pull request #48629 at sha a524aee

@auto-submit auto-submit bot merged commit d3dbd42 into flutter:main Jan 22, 2024
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 22, 2024
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 22, 2024
@engine-flutter-autoroll
d3dbd4225 [web] Bootstrap tests without implicit view by default (flu…
73c97dc 
…tter/engine#48629)
@ditman
Copy link
Member

ditman commented Jan 23, 2024

This one disappeared from my notifications, for good reason! Good one!

auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Jan 23, 2024
@engine-flutter-autoroll
Roll Flutter Engine from b069d7f8f1fd to d3dbd4225e08 (3 revisions) (#…
38be137 
…142005)

flutter/engine@b069d7f...d3dbd42

2024-01-22 [email protected] [web] Bootstrap tests without implicit view by default (flutter/engine#48629)
2024-01-22 [email protected] Roll Skia from bbb0d6feaf1c to fa5f2461554f (1 revision) (flutter/engine#49945)
2024-01-22 [email protected] Roll Dart SDK from dc389e4a01f3 to 9470ea6b00a5 (1 revision) (flutter/engine#49944)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@mdebbar mdebbar deleted the implicit_view_tests branch January 30, 2024 15:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@yjbanov yjbanov yjbanov approved these changes

@ditman ditman Awaiting requested review from ditman

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App platform-web Code specifically for the web engine will affect goldens
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[web:engine] improve programmatic engine bootstrap API for multi-view
3 participants
@mdebbar @ditman @yjbanov