Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[Impeller] remove trace events that have outlived their usefulness. #48856

Merged
merged 1 commit into from
Dec 11, 2023
Merged

[Impeller] remove trace events that have outlived their usefulness. #48856

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions impeller/renderer/backend/vulkan/allocator_vk.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,8 +91,6 @@ AllocatorVK::AllocatorVK(std::weak_ptr<Context> context,
const vk::Instance& instance,
const CapabilitiesVK& capabilities)
: context_(std::move(context)), device_holder_(device_holder) {
TRACE_EVENT0("impeller", "CreateAllocatorVK");

auto limits = physical_device.getProperties().limits;
max_texture_size_.width = max_texture_size_.height =
limits.maxImageDimension2D;
Expand Down Expand Up @@ -273,7 +271,6 @@ class AllocatedTextureSourceVK final : public TextureSourceVK {
bool supports_framebuffer_fetch)
: TextureSourceVK(desc), resource_(std::move(resource_manager)) {
FML_DCHECK(desc.format != PixelFormat::kUnknown);
TRACE_EVENT0("impeller", "CreateDeviceTexture");
vk::ImageCreateInfo image_info;
image_info.flags = ToVKImageCreateFlags(desc.type);
image_info.imageType = vk::ImageType::e2D;
Expand Down Expand Up @@ -402,7 +399,6 @@ class AllocatedTextureSourceVK final : public TextureSourceVK {
// |Allocator|
std::shared_ptr<Texture> AllocatorVK::OnCreateTexture(
const TextureDescriptor& desc) {
TRACE_EVENT0("impeller", "AllocatorVK::OnCreateTexture");
if (!IsValid()) {
return nullptr;
}
Expand Down Expand Up @@ -436,7 +432,6 @@ void AllocatorVK::DidAcquireSurfaceFrame() {
// |Allocator|
std::shared_ptr<DeviceBuffer> AllocatorVK::OnCreateBuffer(
const DeviceBufferDescriptor& desc) {
TRACE_EVENT0("impeller", "AllocatorVK::OnCreateBuffer");
vk::BufferCreateInfo buffer_info;
buffer_info.usage = vk::BufferUsageFlagBits::eVertexBuffer |
vk::BufferUsageFlagBits::eIndexBuffer |
Expand Down
2 changes: 0 additions & 2 deletions impeller/renderer/backend/vulkan/command_pool_vk.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,8 +212,6 @@ std::optional<vk::UniqueCommandPool> CommandPoolRecyclerVK::Reuse() {
}

void CommandPoolRecyclerVK::Reclaim(vk::UniqueCommandPool&& pool) {
TRACE_EVENT0("impeller", "ReclaimCommandPool");

// Reset the pool on a background thread.
auto strong_context = context_.lock();
if (!strong_context) {
Expand Down
6 changes: 0 additions & 6 deletions impeller/renderer/backend/vulkan/descriptor_pool_vk.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,8 +116,6 @@ DescriptorPoolVK::AllocateDescriptorSets(

void DescriptorPoolRecyclerVK::Reclaim(vk::UniqueDescriptorPool&& pool,
uint32_t allocated_capacity) {
TRACE_EVENT0("impeller", "DescriptorPoolRecyclerVK::Reclaim");

// Reset the pool on a background thread.
auto strong_context = context_.lock();
if (!strong_context) {
Expand Down Expand Up @@ -172,8 +170,6 @@ DescriptorPoolAndSize DescriptorPoolRecyclerVK::Get(uint32_t minimum_capacity) {

DescriptorPoolAndSize DescriptorPoolRecyclerVK::Create(
uint32_t minimum_capacity) {
TRACE_EVENT0("impeller", "DescriptorPoolRecyclerVK::Create");

FML_DCHECK(Allocation::NextPowerOfTwoSize(minimum_capacity) ==
minimum_capacity);
auto strong_context = context_.lock();
Expand Down Expand Up @@ -204,8 +200,6 @@ DescriptorPoolAndSize DescriptorPoolRecyclerVK::Create(

std::optional<DescriptorPoolAndSize> DescriptorPoolRecyclerVK::Reuse(
uint32_t minimum_capacity) {
TRACE_EVENT0("impeller", "DescriptorPoolRecyclerVK::Reuse");

FML_DCHECK(Allocation::NextPowerOfTwoSize(minimum_capacity) ==
minimum_capacity);
Lock lock(recycled_mutex_);
Expand Down
1 change: 0 additions & 1 deletion impeller/renderer/backend/vulkan/fence_waiter_vk.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,6 @@ FenceWaiterVK::~FenceWaiterVK() {

bool FenceWaiterVK::AddFence(vk::UniqueFence fence,
const fml::closure& callback) {
TRACE_EVENT0("flutter", "FenceWaiterVK::AddFence");
if (!fence || !callback) {
return false;
}
Expand Down