This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Impeller] recycle glyph atlas texture more aggressively. #48888
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matanlurey
approved these changes
Dec 11, 2023
| @@ -446,6 +446,18 @@ std::shared_ptr<GlyphAtlas> TypographerContextSkia::CreateGlyphAtlas( | |||
| } | |||
| atlas_context_skia.UpdateBitmap(bitmap); | |||
|
|
|||
| // If the new atlas size is the same size as the previous texture, reuse the | |||
| // texture and treat this as an updated that replaces all glyphs. | |||
| if (last_atlas && last_atlas->GetTexture() && | |||
There was a problem hiding this comment.
Pull out last_atlas->GetTexture() so that we don't need to reference it 4 times?
jonahwilliams
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 12, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Dec 12, 2023
…139951) flutter/engine@ea1a306...362d0cb 2023-12-12 [email protected] [Impeller] recycle glyph atlas texture more aggressively. (flutter/engine#48888) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we need to remake the glyph atlas texture but the size is the same, then reuse the old texture.
For more context, see flutter/flutter#138798 which is much slower in Impeller. This change does not fix the problem by itself.