This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[web] Handle resizes at the view level #48892
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ditman
reviewed
Dec 11, 2023
Comment on lines
+213
to
+221
| final bool isEditingOnMobile = | ||
| isMobile && !_isRotation(newPhysicalSize) && textEditing.isEditing; | ||
| if (isEditingOnMobile) { | ||
| _computeOnScreenKeyboardInsets(true); | ||
| } else { | ||
| _physicalSize = newPhysicalSize; | ||
| // When physical size changes this value has to be recalculated. | ||
| _computeOnScreenKeyboardInsets(false); | ||
| } |
There was a problem hiding this comment.
I'm 99% sure this bit only matters when the app is embedded in full-screen mode (the only one that really computes keyboard insets).
Can we make this didResize something that is overridable in the Implicit view + full-screen implementation, and move this version of the logic there?
The case of embedded views in custom elements shouldn't worry about this. WDYT?
There was a problem hiding this comment.
What you are suggesting makes sense. But I would like to do it in a separate PR when I have the time to refactor it and test it properly.
ditman
reviewed
Dec 11, 2023
| @@ -61,6 +64,7 @@ base class EngineFlutterView implements ui.FlutterView { | |||
| // hot restart. | |||
| embeddingStrategy.attachViewRoot(dom.rootElement); | |||
| pointerBinding = PointerBinding(this); | |||
| onResize.listen(_didResize); | |||
There was a problem hiding this comment.
Do we need to stop listening on dispose of the view?
There was a problem hiding this comment.
I'm not sure, since we are closing the stream on dispose anyway. I'll remove the listener too just to be safe.
8 tasks
mdebbar
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 12, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 12, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 12, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 12, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 12, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 12, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 12, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 12, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 12, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 13, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 13, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 13, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 13, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 13, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 13, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 13, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 13, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 13, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 13, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 13, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 13, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 13, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Dec 13, 2023
…140084) flutter/engine@9039ac7...fc32677 2023-12-13 [email protected] Revert Dart SDK back to 3.3.0-219.0.dev (flutter/engine#48990) 2023-12-13 [email protected] [Impeller] Use direct tessellation geometry for simple clip shapes (flutter/engine#48959) 2023-12-13 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[Android] Re-land "Add target to have linux_android_emulator_tests run on AVDs with Android 33 & 34"" (flutter/engine#48988) 2023-12-13 [email protected] Add a constructor for `GlyphInfo`. (flutter/engine#48971) 2023-12-13 [email protected] [Windows] Refactor surface manager mocking (flutter/engine#48953) 2023-12-13 [email protected] Roll Skia from 6e5bd9b1d91d to f3401c6186c1 (2 revisions) (flutter/engine#48981) 2023-12-13 [email protected] Roll Skia from 1e63c048ded7 to 6e5bd9b1d91d (1 revision) (flutter/engine#48973) 2023-12-13 [email protected] Roll Skia from 927f20598b11 to 1e63c048ded7 (1 revision) (flutter/engine#48968) 2023-12-13 [email protected] Roll Dart SDK from 17143c130ab3 to 114f2e8de3e5 (1 revision) (flutter/engine#48969) 2023-12-13 [email protected] Workarounds for clang-tidy warnings in the next roll of Clang (flutter/engine#48963) 2023-12-13 [email protected] Migrate `impeller/**.h` to header guards. (flutter/engine#48962) 2023-12-13 [email protected] Roll Dart SDK from 02f28120470f to 17143c130ab3 (1 revision) (flutter/engine#48961) 2023-12-13 [email protected] [Android] Re-land "Add target to have linux_android_emulator_tests run on AVDs with Android 33 & 34" (flutter/engine#48936) 2023-12-13 [email protected] Roll Skia from 49e32eb178a7 to 927f20598b11 (3 revisions) (flutter/engine#48956) 2023-12-13 [email protected] [web:multiview] Make CanvasKitRenderer listen for view creation/disposal events (flutter/engine#48812) 2023-12-12 [email protected] Move `third_party/swiftshader`, roll buildroot `DEPS`. (flutter/engine#48946) 2023-12-12 [email protected] [Impeller] Direct tessellation of simple filled round rects (flutter/engine#48919) 2023-12-12 [email protected] Roll Skia from 8e8d92ac1536 to 49e32eb178a7 (1 revision) (flutter/engine#48949) 2023-12-12 [email protected] Roll Dart SDK from a677378ae254 to 02f28120470f (1 revision) (flutter/engine#48945) 2023-12-12 [email protected] Roll Skia from 43a400456ab4 to 8e8d92ac1536 (1 revision) (flutter/engine#48941) 2023-12-12 [email protected] Roll Skia from 3678212a85b8 to 43a400456ab4 (2 revisions) (flutter/engine#48939) 2023-12-12 [email protected] Roll `buildroot` and delete `libxml`. (flutter/engine#48906) 2023-12-12 [email protected] Roll Skia from 16298087c277 to 3678212a85b8 (2 revisions) (flutter/engine#48934) 2023-12-12 [email protected] Manual roll of Dart SDK from 82c4571bb2de to a677378ae254 (flutter/engine#48933) 2023-12-12 [email protected] Roll Skia from 7685acfb6221 to 16298087c277 (1 revision) (flutter/engine#48931) 2023-12-12 [email protected] [web] Handle resizes at the view level (flutter/engine#48892) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, in multi-view mode, when the user resizes the window, Flutter views don't respond to the resize. This is because
FlutterViewEmbedderis the one responding to resize events. ButFlutterViewEmbedderonly works with the implicit view, so multi views didn't respond to resize events.This PR moves the responsibility of responding to resize events from
FlutterViewEmbeddertoEngineFlutterView. Also, tests.Part of flutter/flutter#134443