This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Delete SemanticsUpdateBuilderNew and all references and usages
#49139
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
This was referenced Dec 16, 2023
bartekpacia
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 18, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 18, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 18, 2023
bartekpacia
deleted the
chore/semantics_update_builder_migration_part5
branch
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 18, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 18, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Dec 18, 2023
…140350) flutter/engine@92d88c7...632103f 2023-12-18 [email protected] Convert chromium wheel delta to physical pixels on macOS (flutter/engine#49028) 2023-12-18 [email protected] Roll Skia from 3de801338767 to 63bed826008e (1 revision) (flutter/engine#49200) 2023-12-18 [email protected] Roll Dart SDK from ff7e92c7886d to b21443096387 (1 revision) (flutter/engine#49199) 2023-12-18 [email protected] Roll Skia from 83f8fe8bbcee to 3de801338767 (2 revisions) (flutter/engine#49195) 2023-12-18 [email protected] Roll Skia from 10e7ee119ea9 to 83f8fe8bbcee (1 revision) (flutter/engine#49193) 2023-12-18 [email protected] Delete `SemanticsUpdateBuilderNew` and all references and usages (flutter/engine#49139) 2023-12-18 [email protected] Opt into unstable libcxx ABI and add a custom namespace. (flutter/engine#49002) 2023-12-18 [email protected] Roll Skia from 4b2639427e7e to 10e7ee119ea9 (10 revisions) (flutter/engine#49191) 2023-12-18 [email protected] Roll Dart SDK from e1a26302800d to ff7e92c7886d (1 revision) (flutter/engine#49185) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
CoderDake
pushed a commit
to CoderDake/flutter
that referenced
this pull request
Dec 28, 2023
…lutter#140350) flutter/engine@92d88c7...632103f 2023-12-18 [email protected] Convert chromium wheel delta to physical pixels on macOS (flutter/engine#49028) 2023-12-18 [email protected] Roll Skia from 3de801338767 to 63bed826008e (1 revision) (flutter/engine#49200) 2023-12-18 [email protected] Roll Dart SDK from ff7e92c7886d to b21443096387 (1 revision) (flutter/engine#49199) 2023-12-18 [email protected] Roll Skia from 83f8fe8bbcee to 3de801338767 (2 revisions) (flutter/engine#49195) 2023-12-18 [email protected] Roll Skia from 10e7ee119ea9 to 83f8fe8bbcee (1 revision) (flutter/engine#49193) 2023-12-18 [email protected] Delete `SemanticsUpdateBuilderNew` and all references and usages (flutter/engine#49139) 2023-12-18 [email protected] Opt into unstable libcxx ABI and add a custom namespace. (flutter/engine#49002) 2023-12-18 [email protected] Roll Skia from 4b2639427e7e to 10e7ee119ea9 (10 revisions) (flutter/engine#49191) 2023-12-18 [email protected] Roll Dart SDK from e1a26302800d to ff7e92c7886d (1 revision) (flutter/engine#49185) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR completest the migration by removing
SemanticsUpdateBuilderNewfrom the engine.This is mainly targeted at flutter/flutter#17988
Steps:
part 1: [engine] add
SemanticsUpdateBuilderNew#47961part 2: [flutter] use
SemanticsUpdateBuilderNewflutter/flutter#138331part 3: [engine] update
SemanticsUpdateBuilderto be the same asSemanticsUpdateBuilderNew#48882part 4: [flutter] use (now updated)
SemanticsUpdateBuilderagain flutter/flutter#139942part 5: [engine] remove
SemanticsBuilderNew<-- we are herePre-launch Checklist
///).