Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Roll src/third_party/skia/ 9874bf1bc..52e16d984 (135 commits) #4958

Merged
merged 1 commit into from
Apr 10, 2018
Merged

Roll src/third_party/skia/ 9874bf1bc..52e16d984 (135 commits) #4958

merged 1 commit into from
Apr 10, 2018

Conversation

rmistry
Copy link
Contributor

@rmistry rmistry commented Apr 10, 2018

No description provided.

@rmistry
Roll src/third_party/skia/ 9874bf1..52e16d9 (135 commits)
e40872b 
https://skia.googlesource.com/skia.git/+log/9874bf1bcecd..52e16d984898

$ git log 9874bf1..52e16d9 --date=short --no-merges --format='%ad %ae %s'
2018-04-10 egdaniel Update getBackendInfo calls on GrBackendTexture to support VkImageLayout better.
2018-04-10 caryclark one more path is rect bug
2018-04-09 caryclark fix path to rect when missing close verb
2018-04-09 benjaminwagner Omit skbug6653 on internal device.
2018-04-09 brianosman Remove SkDEBUGFAIL for non-invertible XYZ matrix
2018-04-09 angle-skia-autoroll Roll third_party/externals/angle2/ 6c59e4a..0ce016c (2 commits)
2018-04-06 reed identify interesting cubic points
2018-04-09 mtklein use commonPaint for all raster pipeline
2018-04-06 benjaminwagner Upgrade Debian9 bots to 9.4.
2018-04-09 bsalomon Reland "Remove deprectated GrContext::MakeGL overloads that take raw ptr"
2018-04-09 skcms-skia-autoroll Roll third_party/externals/skcms/ 8a727815d..16a9cebff (1 commit)
2018-04-06 csmartdalton ccpr: Remove WindMethod from GrCCCoverageProcessor
2018-04-09 angle-skia-autoroll Roll third_party/externals/angle2/ 6c7ab7f..6c59e4a (3 commits)
2018-04-06 bsalomon Add canvas2D fast paths to new read/write pixels code paths.
2018-04-09 egdaniel Make sure GrBackendTextures are valid before starting to do things with them
2018-04-06 brianosman Remove code that was only used by the old debugger
2018-04-08 csmartdalton Implement Sk2f::Store2
2018-04-09 angle-skia-autoroll Roll third_party/externals/angle2/ 5ae64c9..6c7ab7f (1 commit)
2018-04-08 herb Revert "Remove all notion of transport from the API."
2018-04-07 angle-skia-autoroll Roll third_party/externals/angle2/ e547aac..5ae64c9 (1 commit)
2018-04-05 halcanary SkPDF: smarter Jpeg when libjpeg-turbo is present
2018-04-07 angle-skia-autoroll Roll third_party/externals/angle2/ d2488ab..e547aac (2 commits)
2018-04-06 herb Better layer tracking fidelity
2018-04-06 angle-skia-autoroll Roll third_party/externals/angle2/ b8e3966..d2488ab (2 commits)
2018-04-06 skcms-skia-autoroll Roll third_party/externals/skcms/ 24c91d143..8a727815d (1 commit)
2018-04-06 brianosman Remove scanlineOrder switch statements that always do the same thing
2018-04-06 reed detect if makeOffset failed
2018-04-05 csmartdalton vulkan: Fix an optimus-related failure with vkEnumeratePhysicalDevices
2018-04-06 egdaniel Make generated effects from sksl fp files not need SK_SUPPORT_GPU
2018-04-05 herb Remove all notion of transport from the API.
2018-04-04 halcanary SkRegion: Use less memory for SkRegion::Oper
2018-04-06 brianosman Remove old debugger (it no longer builds)
2018-04-06 liyuqian Revert "Exercise the threaded backend in test bots"
2018-04-06 egdaniel Remove unneeded SK_SUPPORT_GPU checks in gpu only files.
2018-04-06 halcanary Region Op Fuzzer
2018-04-05 csmartdalton ccpr: Make curve corners more seamless
2018-04-05 brianosman Remove SK_SUPPORT_LEGACY_BLURMASKFILTER
2018-04-06 bsalomon Add versions of MakeGL() that don't require include GrGLInterface.h in order to use the GrGLMakeNativeInterface
2018-04-06 egdaniel Don't use GrPixelConfig value as proxy for valid on GrBackendSurface.
2018-04-05 liyuqian Exercise the threaded backend in test bots
2018-04-06 angle-skia-autoroll Roll third_party/externals/angle2/ c3755fc..b8e3966 (1 commit)
2018-04-06 update-docs Update markdown files
2018-04-05 angle-skia-autoroll Roll third_party/externals/angle2/ dd196e0..c3755fc (5 commits)
2018-04-05 caryclark remove SK_IGNORE_TO_STRING
2018-03-29 bungeman Distinguish between glyphs with empty path and no path.
2018-04-05 skcms-skia-autoroll Roll third_party/externals/skcms/ 6959d4597..24c91d143 (1 commit)
2018-04-05 skcms-skia-autoroll Roll third_party/externals/skcms/ d75edb2e3..6959d4597 (1 commit)
2018-04-05 skcms-skia-autoroll Roll third_party/externals/skcms/ a7974d9f6..d75edb2e3 (1 commit)
2018-04-05 fmalita Clip SlideDir slides to their declared dimensions
2018-04-05 bungeman Mac to better serialize OTTO fonts.
2018-04-05 robertphillips Revert "Remove deprectated GrContext::MakeGL overloads that take raw ptr"
2018-04-05 bsalomon Remove SK_DISABLE_TEXTURE_OP_AA
2018-04-05 fmalita [viewer] Consolidate external slide loading
2018-04-05 liyuqian Flush before snap SkThreadedBMPDevice
2018-04-05 skcms-skia-autoroll Roll third_party/externals/skcms/ 3cb9ba6ae..a7974d9f6 (3 commits)
2018-04-04 bryct Update 'Working in a Chromium repo' documentation.
2018-04-05 kjlubick Avoid nonsortable rects in drawRect/drawOval
2018-04-04 bsalomon Remove deprectated GrContext::MakeGL overloads that take raw ptr
2018-04-05 bsalomon Add maxTextureSize()/maxRenderTargetSize() to GrContext
2018-04-05 fmalita Viewer SVG support
2018-04-04 bungeman Via*::draw to finish before checking.
2018-04-05 reed replace size-alignment assert with round-down
2018-04-05 angle-skia-autoroll Roll third_party/externals/angle2/ bc54342..dd196e0 (14 commits)
2018-04-05 skcms-skia-autoroll Roll third_party/externals/skcms/ d26d270c8..3cb9ba6ae (7 commits)
2018-04-02 halcanary SkPDF: implement xheight for type3 fonts
2018-04-05 robertphillips Add GrBackendTexture/RenderTarget accessors to SkSurface
2018-04-05 robertphillips Add SK_API to SkSurfaceCharacterization
2018-04-03 halcanary experimental/tools: minor code cleanup
2018-04-04 brianosman Workaround for lack of ESSL3 external image extension on older Samsung devices
2018-04-05 caryclark tweak SkImage documentation
2018-04-05 robertphillips Fix iOS bot in Chrome CQ
2018-04-05 update-docs Update markdown files
2018-04-04 bsalomon Avoid calling glGetString(GL_EXTENSIONS) on core profiles
2018-04-04 bsalomon Stop using clear-as-draw workaround on newer Intel drivers on macOS
2018-04-04 liyuqian Ensure that pointers/arrays are valid until flush in threaded backend
2018-04-04 benjaminwagner Add loongson3a Build jobs.
2018-04-04 robertphillips Add GrBackendTexture accessor to SkImage (take 2)
2018-04-04 reed move SkIPoint16 to private header
2018-04-04 benjaminwagner Update mips64el_toolchain_linux to GCC 7
2018-04-04 fmalita Fix SkLocalMatrixShader nesting semantics
2018-04-04 egdaniel Make sure we set the origin when initDescForDstCopy fails
2018-04-04 fmalita Banish SkShaderBase::isRasterPipelineOnly()
2018-03-22 liyuqian Fix drawBitmapRect in the threaded backend
2018-04-03 mtklein add Mac ASAN bots
2018-04-04 skcms-skia-autoroll Roll skia/third_party/externals/skcms/ 7dd7eed65..d26d270c8 (1 commit)
2018-04-04 djsollen Tag the unique keys of lazy images.
2018-04-04 robertphillips Add SkSurfaceCharacterization operator== && !=
2018-04-04 bsalomon Revert "Revert "Make SkSL GLSL generator declare sk_FragColor inout when EXT fb fetch is used.""
2018-04-04 angle-skia-autoroll Roll skia/third_party/externals/angle2/ 5d232d5..bc54342 (6 commits)
2018-04-04 egdaniel Don't use the inner radius when not stroking in DIEllipse
2018-04-04 bsalomon Revert "Make SkSL GLSL generator declare sk_FragColor inout when EXT fb fetch is used."
2018-04-03 benjaminwagner Add mips64el_toolchain_linux asset.
2018-04-03 bsalomon Make SkSL GLSL generator declare sk_FragColor inout when EXT fb fetch is used.
2018-04-04 egdaniel Handle perspective scales in GrPathUtil scaleToleranceToSrc
2018-04-03 robertphillips Hide GrPixelConfig in SkSurfaceCharacterization
2018-04-04 skcms-skia-autoroll Roll skia/third_party/externals/skcms/ 770177dc9..7dd7eed65 (1 commit)
2018-04-03 khushalsagar Add API for SkTextBlob serialization into caller's memory.
2018-04-03 herb Clean up buffering and serializatoin.
2018-04-03 egdaniel Check if fan point is finite in GrAAConvexPathRenderer.
2018-04-03 caryclark fix global method indentation
(...)

Created with:
  roll-dep src/third_party/skia
@brianosman brianosman merged commit 11882ab into flutter:master Apr 10, 2018
@aam
Copy link
Member

aam commented Apr 10, 2018

This has broken Flutter Linux and Mac engine builds:
https://build.chromium.org/p/client.flutter/builders/Linux%20Engine/builds/2496
https://build.chromium.org/p/client.flutter/builders/Mac%20Engine/builds/2569

[630/2232] CXX obj/flutter/vulkan/vulkan/vulkan_swapchain.o
FAILED: obj/flutter/vulkan/vulkan/vulkan_swapchain.o 
/b/build/slave/cache/goma_client/gomacc ../../buildtools/linux-x64/clang/bin/clang++ -MMD -MF obj/flutter/vulkan/vulkan/vulkan_swapchain.o.d -DUSE_OPENSSL=1 -DUSE_OPENSSL_CERTS=1 -DNO_TCMALLOC -DTOOLCHAIN_VERSION=ae85410691b10aa2469695c2421b1fe751843e64 -D_FILE_OFFSET_BITS=64 -DANDROID -DHAVE_SYS_UIO_H -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D_FORTIFY_SOURCE=2 -D__compiler_offsetof=__builtin_offsetof -Dnan=__builtin_nan -D__GNU_SOURCE=1 -D_LIBCPP_ENABLE_THREAD_SAFETY_ANNOTATIONS -DNDEBUG -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -DSK_GAMMA_APPLY_TO_A8 -DSK_GAMMA_EXPONENT=1.4 -DSK_GAMMA_CONTRAST=0.0 -DSK_ALLOW_STATIC_GLOBAL_INITIALIZERS=0 -DSK_ENABLE_DISCRETE_GPU -DSK_VULKAN -DSK_VULKAN_HEADER=\"flutter/vulkan/skia_vulkan_header.h\" -DSK_HAS_JPEG_LIBRARY -DSK_SUPPORT_PDF -DSK_HAS_PNG_LIBRARY -DSK_HAS_WEBP_LIBRARY -DSK_XML -DSK_DISABLE_EXPLICIT_GPU_RESOURCE_ALLOCATION -DSK_DISABLE_RENDER_TARGET_SORTING -I../.. -Igen -I../../third_party/vulkan/src -I../.. -I../../third_party/skia/include/private -I../../third_party/skia/src/c -I../../third_party/skia/src/codec -I../../third_party/skia/src/core -I../../third_party/skia/src/effects -I../../third_party/skia/src/fonts -I../../third_party/skia/src/image -I../../third_party/skia/src/images -I../../third_party/skia/src/lazy -I../../third_party/skia/src/opts -I../../third_party/skia/src/pathops -I../../third_party/skia/src/pdf -I../../third_party/skia/src/ports -I../../third_party/skia/src/sfnt -I../../third_party/skia/src/shaders -I../../third_party/skia/src/shaders/gradients -I../../third_party/skia/src/sksl -I../../third_party/skia/src/utils -I../../third_party/skia/src/utils/win -I../../third_party/skia/src/xml -I../../third_party/skia/third_party/gif -I../../third_party/skia/src/gpu -I../../garnet/public -I../../topaz/public -Igen/garnet/public -Igen/topaz/public -I../../third_party/skia/include/android -I../../third_party/skia/include/c -I../../third_party/skia/include/codec -I../../third_party/skia/include/config -I../../third_party/skia/include/core -I../../third_party/skia/include/effects -I../../third_party/skia/include/encode -I../../third_party/skia/include/gpu -I../../third_party/skia/include/gpu/gl -I../../third_party/skia/include/atlastext -I../../third_party/skia/include/pathops -I../../third_party/skia/include/ports -I../../third_party/skia/include/svg -I../../third_party/skia/include/utils -I../../third_party/skia/include/utils/mac -I../../third_party/skia/include/gpu/vk -fno-strict-aliasing -march=armv7-a -mfloat-abi=softfp -mtune=generic-armv7-a -mthumb -fPIC -pipe -fcolor-diagnostics -ffunction-sections -funwind-tables -fno-short-enums --target=arm-linux-androideabi -mfpu=neon -Wall -Wextra -Wendif-labels -Werror -Wno-missing-field-initializers -Wno-unused-parameter -isystem../../third_party/android_tools/ndk/sources/cxx-stl/llvm-libc++/libcxx/include -isystem../../third_party/android_tools/ndk/sources/cxx-stl/llvm-libc++abi/libcxxabi/include -isystem../../third_party/android_tools/ndk/sources/android/support/include -fvisibility=hidden --sysroot=/b/build/slave/Linux_Engine/build/src/third_party/android_tools/ndk/platforms/android-16/arch-arm -Wheader-hygiene -Wstring-conversion -Wthread-safety -Os -fno-ident -fdata-sections -ffunction-sections -fomit-frame-pointer -g2 -fvisibility-inlines-hidden -std=c++14 -fno-rtti -fno-exceptions -c ../../flutter/vulkan/vulkan_swapchain.cc -o obj/flutter/vulkan/vulkan/vulkan_swapchain.o
../../flutter/vulkan/vulkan_swapchain.cc:225:23: error: no matching constructor for initialization of 'const GrVkImageInfo'
  const GrVkImageInfo image_info = {
                      ^            ~
../../third_party/skia/include/gpu/vk/GrVkTypes.h:86:5: note: candidate constructor not viable: requires 2 arguments, but 6 were provided
    GrVkImageInfo(const GrVkImageInfo& info, VkImageLayout layout)
    ^
../../third_party/skia/include/gpu/vk/GrVkTypes.h:66:8: note: candidate constructor (the implicit copy constructor) not viable: requires 1 argument, but 6 were provided
struct GrVkImageInfo {
       ^
../../third_party/skia/include/gpu/vk/GrVkTypes.h:66:8: note: candidate constructor (the implicit move constructor) not viable: requires 1 argument, but 6 were provided
../../third_party/skia/include/gpu/vk/GrVkTypes.h:78:5: note: candidate constructor not viable: requires 0 arguments, but 6 were provided
    GrVkImageInfo()
    ^
1 error generated.

aam added a commit to aam/engine that referenced this pull request Apr 10, 2018
@aam
Revert "Roll src/third_party/skia/ 9874bf1..52e16d9 (135 commits) (fl…
05e8106 
…utter#4958)"

This reverts commit 11882ab as it
breaks Linux and Mac buildbots.
@brianosman
Copy link
Contributor

Sorry, I was about to revert, but looks like you got it already. We'll fix this on the Skia side and land an updated roll later.

@aam
Copy link
Member

aam commented Apr 10, 2018

I haven't reverted it yet, I added a revert into PR I'm still working on :-) Please feel free to go ahead and revert it if you have it lined up.

brianosman added a commit that referenced this pull request Apr 10, 2018
@brianosman
Revert "Roll src/third_party/skia/ 9874bf1..52e16d9 (135 commits) (#4958
06b2839 
)"

This reverts commit 11882ab.
@brianosman brianosman mentioned this pull request Apr 10, 2018
Merged
brianosman added a commit that referenced this pull request Apr 10, 2018
@brianosman
Revert "Roll src/third_party/skia/ 9874bf1..52e16d9 (135 commits) (#4958
132ebdd 
)" (#4961)

This reverts commit 11882ab.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rmistry @aam @brianosman @googlebot