Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[Windows] Set cursor immediately when framework requests update #49784

Merged
merged 2 commits into from
Jan 25, 2024
Merged

[Windows] Set cursor immediately when framework requests update #49784

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0a9d735
Set cursor immediately when framework requests update
hasali19 Jan 14, 2024
ed95675
Add test for updating cursor
hasali19 Jan 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion shell/platform/windows/flutter_window.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,7 +177,7 @@ PhysicalWindowBounds FlutterWindow::GetPhysicalWindowBounds() {
}

void FlutterWindow::UpdateFlutterCursor(const std::string& cursor_name) {
current_cursor_ = GetCursorByName(cursor_name);
SetFlutterCursor(GetCursorByName(cursor_name));
}

void FlutterWindow::SetFlutterCursor(HCURSOR cursor) {
Expand Down
7 changes: 7 additions & 0 deletions shell/platform/windows/flutter_window_unittests.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -436,5 +436,12 @@ TEST(FlutterWindowTest, PosthumousWindowMessage) {
EXPECT_GE(msg_count, 1);
}

TEST(FlutterWindowTest, UpdateCursor) {
FlutterWindow win32window(100, 100);
win32window.UpdateFlutterCursor("text");
HCURSOR cursor = ::GetCursor();
EXPECT_EQ(cursor, ::LoadCursor(nullptr, IDC_IBEAM));
}

} // namespace testing
} // namespace flutter