This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Impeller] add missing barrier to compute tessellator. #50108
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@test-exemption-reviewer" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
gaaclarke
reviewed
Jan 27, 2024
|
I haven't tried yet but I obviously should. Will do while this is building. |
|
I ran this 100 times locally with / without the patch and confirmed this fixes the flake for me. |
gaaclarke
approved these changes
Jan 27, 2024
jonahwilliams
added
the
autosubmit
|
Landing on red to fix tree. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 27, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jan 27, 2024
…142362) flutter/engine@2687ddb...2adad88 2024-01-27 [email protected] Roll Skia from 6279c88b9e29 to b9b80230c87b (4 revisions) (flutter/engine#50110) 2024-01-27 [email protected] [Impeller] add missing barrier to compute tessellator. (flutter/engine#50108) 2024-01-27 [email protected] [Android] Cache GPU resources using HardwareBuffer's id as key (flutter/engine#50028) 2024-01-27 [email protected] Move Mac builder_cache to prod (flutter/engine#50044) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
auto-submit bot
added a commit
to flutter/flutter
that referenced
this pull request
Jan 27, 2024
…isions)" (#142366) Reverts #142362 Initiated by: jonahwilliams This change reverts the following previous change: Original Description: flutter/engine@2687ddb...2adad88 2024-01-27 [email protected] Roll Skia from 6279c88b9e29 to b9b80230c87b (4 revisions) (flutter/engine#50110) 2024-01-27 [email protected] [Impeller] add missing barrier to compute tessellator. (flutter/engine#50108) 2024-01-27 [email protected] [Android] Cache GPU resources using HardwareBuffer's id as key (flutter/engine#50028) 2024-01-27 [email protected] Move Mac builder_cache to prod (flutter/engine#50044) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 27, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 27, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 27, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jan 27, 2024
…142369) flutter/engine@2687ddb...95e9a15 2024-01-27 [email protected] Cache Impeller paths in the DisplayList to amortize conversion (flutter/engine#50076) 2024-01-27 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[Android] Cache GPU resources using HardwareBuffer's id as key" (flutter/engine#50114) 2024-01-27 [email protected] Roll Dart SDK from 58665e3dee42 to 7ae508ee09a3 (1 revision) (flutter/engine#50112) 2024-01-27 [email protected] Roll Fuchsia Linux SDK from WHlwlOwznFknNm5IS... to GBTh3gOOgmndwT70X... (flutter/engine#50111) 2024-01-27 [email protected] Roll Skia from 6279c88b9e29 to b9b80230c87b (4 revisions) (flutter/engine#50110) 2024-01-27 [email protected] [Impeller] add missing barrier to compute tessellator. (flutter/engine#50108) 2024-01-27 [email protected] [Android] Cache GPU resources using HardwareBuffer's id as key (flutter/engine#50028) 2024-01-27 [email protected] Move Mac builder_cache to prod (flutter/engine#50044) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from WHlwlOwznFkn to GBTh3gOOgmnd If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the flake on ToT
https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8757792078669575121/+/u/test:_Host_Tests_for_host_debug_unopt/stdout