Support accessibility back gesture to pop route from view controller

[jmagman]

Adapted suggestion from flutter/flutter#74246 (comment) to pop the route if the view controller route if accessibilityPerformEscape is called at that level in the responder chain.

Ideally this could know if the route was successfully popped, and only then return YES (halting propagation through the responder chain).

I confirmed by editing https://docs.flutter.dev/cookbook/navigation/navigation-basics#interactive-example as a demo that that the two-finger scrub (move two fingers back and forth three times quickly, making a "z") navigates back to the last route, and that the SementicObject scrub, which already worked, continued to work.

I'm not super familiar with this code, hopefully there aren't further gotchas I'm not thinking of.

Fixes flutter/flutter#74246

Pre-launch Checklist

• I read the Contributor Guide and followed the process outlined there for submitting PRs.
• I read the Tree Hygiene wiki page, which explains my responsibilities.
• I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
• I listed at least one issue that this PR fixes in the description above.
• I added new tests to check the change I am making or feature I am adding, or the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
• I updated/added relevant documentation (doc comments with ///).
• I signed the CLA.
• All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

[jmagman]

FlutterBinaryMessengerRelayTest is no longer in the iOS directory and is tested in common #44395

[jmagman]

Removed in #48162

[jmagman]

There are more folks running these tests on ARM Macs now than x64.

[hellohuanlin]

does the previous 2 line do anything? is it supposed to pick the right engine based on which mac you are running on?

[jmagman]

The previous two lines were my attempt at picking the right engine for you #39213, but it doesn't work because at one of the point it's used the ARCH is unknown 😞

[jmagman]

@Hangyujin are you the best person to review this since @chunhtai is out? Or should I add someone else?

[hellohuanlin]

nit: just if (navigationChannel)

[jmagman]

I don't think we're consistent in the engine, I don't have a preference though.

[hellohuanlin]

does the previous 2 line do anything? is it supposed to pick the right engine based on which mac you are running on?

[vashworth]

Did you also try dismissing a dialog (example: https://api.flutter.dev/flutter/material/showDialog.html)? Seems to me it should probably work too

[vashworth]

LGTM

[jmagman]

Did you also try dismissing a dialog (example: https://api.flutter.dev/flutter/material/showDialog.html)? Seems to me it should probably work too

Confirmed that worked on main and also on this branch.

[jmagman]

Routes and modal combined, showing the modal is dismissed before the route is popped

import 'package:flutter/cupertino.dart';
import 'package:flutter/material.dart';

void main() {
  runApp(const MaterialApp(
    title: 'Navigation Basics',
    home: FirstRoute(),
  ));
}

class FirstRoute extends StatelessWidget {
  const FirstRoute({super.key});

  @override
  Widget build(BuildContext context) {
    return Scaffold(
      appBar: AppBar(
        title: const Text('First Route'),
      ),
      body: Center(
        child: ElevatedButton(
          child: const Text('Open route'),
          onPressed: () {
            Navigator.push(
              context,
              MaterialPageRoute(builder: (context) => const SecondRoute()),
            );
          },
        ),
      ),
    );
  }
}

class SecondRoute extends StatelessWidget {
  const SecondRoute({super.key});

  @override
  Widget build(BuildContext context) {
    return Scaffold(
      appBar: AppBar(
        title: const Text('Second Route'),
      ),
      body: Center(
        child: ElevatedButton(
          onPressed: () {
            Navigator.of(context).restorablePush(_modalBuilder);
          },
          child: const Text('Open Modal'),
        ),
      ),
    );
  }

  @pragma('vm:entry-point')
  static Route<void> _modalBuilder(BuildContext context, Object? arguments) {
    return CupertinoModalPopupRoute<void>(
      builder: (BuildContext context) {
        return CupertinoActionSheet(
          title: const Text('Title'),
          message: const Text('Message'),
          actions: <CupertinoActionSheetAction>[
            CupertinoActionSheetAction(
              child: const Text('Action One'),
              onPressed: () {
                Navigator.pop(context);
              },
            ),
            CupertinoActionSheetAction(
              child: const Text('Action Two'),
              onPressed: () {
                Navigator.pop(context);
              },
            ),
          ],
        );
      },
    );
  }
}

(gesture done at :09 and :13)
https://github.com/flutter/engine/assets/682784/8886cd6e-ab0d-4258-8015-f0dd0ed7329c