This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Reverts "[Fuchsia] only download fuchsia deps when necessary (#51439)" #51500
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![auto-submit[bot]](https://avatars.githubusercontent.com/u/14101776?s=60&v=4){kind=small}
This reverts commit 9162c83.
auto-submit
bot
added
the
revert of
zijiehe-google-com
approved these changes
Mar 18, 2024
fluttergithubbot
approved these changes
Mar 18, 2024
auto-submit
bot
deleted the
revert_9162c8309e247be465bb4fa7173f704c2053b9b3
branch
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 18, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Mar 18, 2024
…145365) flutter/engine@89df726...0ee413e 2024-03-18 [email protected] A native Android unit-testing harness. (flutter/engine#51479) 2024-03-18 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[Fuchsia] only download fuchsia deps when necessary (#51439)" (flutter/engine#51500) 2024-03-18 [email protected] [web] Avoid using `js_util.{jsify,dartify}()` in dart2wasm for converting to JS wrappers (flutter/engine#51375) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts: #51439
Initiated by: zijiehe-google-com
Reason for reverting: broke dart->flutter roller due to the expected licenses not being included without
download_fuchsia_depsin.gclient.Original PR Author: zijiehe-google-com
Reviewed By: {zanderso}
This change reverts the following previous change:
This is a quick follow up of #51072 to only download fuchsia deps (via download_fuchsia_deps gclient arg) when necessary. Considering the pr/51072 is very huge, keeping these condition changes in a separate change would be cleaner.
The wiki has been updated already since setting the download_fuchsia_deps gclient arg explicitly won't break the existing workflow. I also mentioned in the wiki that building and running fuchsia needed a linux box (an explicit assertion in the with_envs.py).
Bug: http://b/40935282
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.