This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Impeller] fixes PlusAdvanced alpha blending / adds alpha blending tests #51787
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaaclarke
changed the title
|
@bdero @jonahwilliams friendly ping |
|
Sorry, missed this last week. |
|
Yet again, I didn't get SkiaGolds report on new goldens. There was no rebase involved this time. Goldens are at https://flutter-engine-gold.skia.org/search?issue=51787&crs=github&patchsets=4&corpus=flutter-engine |
|
Not sure what went wrong, but post submit is red on the new goldens. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 3, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Apr 3, 2024
…146176) flutter/engine@bb4ec2d...ef60a95 2024-04-02 [email protected] [Impeller] fixes PlusAdvanced alpha blending / adds alpha blending tests (flutter/engine#51787) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sorry, I thought going into skia gold and approving them despite the bot messing up would carry over to post submit checks. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#51756 had a bug in it when src alpha was not 1. There was no test coverage for this. I've added the fix and test coverage for all the blends.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.