This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Update embedder example apps to run with the current engine tree #51995
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
jason-simmons
commented
Apr 9, 2024
jason-simmons
commented
- Update ICU data paths for the move of third_party/icu out of the buildroot
- Link with -rdynamic to enable lookup of Dart resource symbols within the app executables
- Use Material 3 text styles that are supported by the current Flutter framework
* Update ICU data paths for the move of third_party/icu out of the buildroot * Link with -rdynamic to enable lookup of Dart resource symbols within the app executables * Use Material 3 text styles that are supported by the current Flutter framework
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@test-exemption-reviewer" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
chinmaygarde
approved these changes
Apr 9, 2024
jason-simmons
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 10, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Apr 10, 2024
…146538) flutter/engine@e4e2748...eaf73cd 2024-04-09 [email protected] Update embedder example apps to run with the current engine tree (flutter/engine#51995) 2024-04-09 [email protected] [Impeller] Refactor KHR swapchains to make it easy to reuse backend agnostic components. (flutter/engine#52002) 2024-04-09 [email protected] Roll Skia from 74b0e26886f0 to 45eeeddb0074 (1 revision) (flutter/engine#52007) 2024-04-09 [email protected] Try postsubmit_overrides for one mac build (flutter/engine#51676) 2024-04-09 [email protected] [Impeller] Remove stencil clipping logic. (flutter/engine#51999) 2024-04-09 [email protected] Roll Skia from a86861d21ae1 to 74b0e26886f0 (2 revisions) (flutter/engine#52000) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
gilnobrega
pushed a commit
to gilnobrega/flutter
that referenced
this pull request
Apr 22, 2024
…lutter#146538) flutter/engine@e4e2748...eaf73cd 2024-04-09 [email protected] Update embedder example apps to run with the current engine tree (flutter/engine#51995) 2024-04-09 [email protected] [Impeller] Refactor KHR swapchains to make it easy to reuse backend agnostic components. (flutter/engine#52002) 2024-04-09 [email protected] Roll Skia from 74b0e26886f0 to 45eeeddb0074 (1 revision) (flutter/engine#52007) 2024-04-09 [email protected] Try postsubmit_overrides for one mac build (flutter/engine#51676) 2024-04-09 [email protected] [Impeller] Remove stencil clipping logic. (flutter/engine#51999) 2024-04-09 [email protected] Roll Skia from a86861d21ae1 to 74b0e26886f0 (2 revisions) (flutter/engine#52000) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.