This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Reverts "Delete engine v1 android embedding (#51229)" #51996
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![auto-submit[bot]](https://avatars.githubusercontent.com/u/14101776?s=60&v=4){kind=small}
This reverts commit b735b76.
auto-submit
bot
added
the
revert of
fluttergithubbot
approved these changes
Apr 9, 2024
auto-submit
bot
deleted the
revert_b735b76bf376ae60bc6cd16ffe214dd66c48454f
branch
gmackall
approved these changes
Apr 9, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 9, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Apr 9, 2024
…146524) flutter/engine@5a824e2...5dca50d 2024-04-09 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Delete engine v1 android embedding (#51229)" (flutter/engine#51996) 2024-04-09 [email protected] Delete engine v1 android embedding (flutter/engine#51229) 2024-04-09 [email protected] better output from engine layer unit test failures (flutter/engine#51975) 2024-04-09 [email protected] Revert "Roll Dart SDK from 78174b41ab0f to 7a5e410f982e (1 revision) (#51980)" (flutter/engine#51990) 2024-04-09 [email protected] [skwasm] Reify the SkPicture pointer as the right type. (flutter/engine#51991) 2024-04-09 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Roll Dart SDK from 7a5e410f982e to db99af14c4bc (1 revision) (#51986)" (flutter/engine#51989) 2024-04-09 [email protected] Move the Dart SDK to //flutter/third_party/dart (flutter/engine#51917) 2024-04-09 [email protected] [macOS] Implement hit testing and handle platform view cursor changes (flutter/engine#43101) 2024-04-09 [email protected] Roll Dart SDK from 7a5e410f982e to db99af14c4bc (1 revision) (flutter/engine#51986) 2024-04-09 [email protected] Roll Dart SDK from 78174b41ab0f to 7a5e410f982e (1 revision) (flutter/engine#51980) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
gmackall
pushed a commit
to gmackall/engine
that referenced
this pull request
Apr 10, 2024
…lutter#51996)" This reverts commit 5dca50d.
gilnobrega
pushed a commit
to gilnobrega/flutter
that referenced
this pull request
Apr 22, 2024
…lutter#146524) flutter/engine@5a824e2...5dca50d 2024-04-09 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Delete engine v1 android embedding (flutter#51229)" (flutter/engine#51996) 2024-04-09 [email protected] Delete engine v1 android embedding (flutter/engine#51229) 2024-04-09 [email protected] better output from engine layer unit test failures (flutter/engine#51975) 2024-04-09 [email protected] Revert "Roll Dart SDK from 78174b41ab0f to 7a5e410f982e (1 revision) (flutter#51980)" (flutter/engine#51990) 2024-04-09 [email protected] [skwasm] Reify the SkPicture pointer as the right type. (flutter/engine#51991) 2024-04-09 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Roll Dart SDK from 7a5e410f982e to db99af14c4bc (1 revision) (flutter#51986)" (flutter/engine#51989) 2024-04-09 [email protected] Move the Dart SDK to //flutter/third_party/dart (flutter/engine#51917) 2024-04-09 [email protected] [macOS] Implement hit testing and handle platform view cursor changes (flutter/engine#43101) 2024-04-09 [email protected] Roll Dart SDK from 7a5e410f982e to db99af14c4bc (1 revision) (flutter/engine#51986) 2024-04-09 [email protected] Roll Dart SDK from 78174b41ab0f to 7a5e410f982e (1 revision) (flutter/engine#51980) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
gmackall
pushed a commit
to gmackall/engine
that referenced
this pull request
Oct 2, 2024
…lutter#51996)" This reverts commit 5dca50d.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts: #51229
Initiated by: gmackall
Reason for reverting: blocking engine->framework roll (I missed some framework code referencing the v1 embedding).
Original PR Author: gmackall
Reviewed By: {matanlurey, reidbaker}
This change reverts the following previous change:
Fixes flutter/flutter#143531
Also fixes a random typo I found
TODO to test this(no more todo):-
test the framework against this as well, probably with a dummy PR changing the engine commit to my branch if this is possiblenot possible, made a best effort removal of framework code in flutter/flutter#144726.-
figure out if the old embedding is used in g3 at allremoved all uses-
figure out exactly what the ShimPluginRegistry/ShimRegistrar are doing, and if fully deleting them was right(see #51229 (comment))Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.