This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[scenarios] test disabling surface clear. #52128
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jason-simmons
approved these changes
Apr 15, 2024
gaaclarke
reviewed
Apr 15, 2024
|
Will do as a follow up, not sure if this will work yet. |
|
Landing on red to fix tree. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 15, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Apr 15, 2024
…146775) flutter/engine@1a13c7d...84238c4 2024-04-15 [email protected] [scenarios] test disabling surface clear. (flutter/engine#52128) 2024-04-12 [email protected] Roll Dart SDK from 3d13dbfb3284 to ac31be3c8546 (8 revisions) (flutter/engine#52084) 2024-04-12 [email protected] Roll Skia from 761f6f7f6250 to 9e20a146c024 (7 revisions) (flutter/engine#52085) 2024-04-12 [email protected] [Windows] Refactor client wrapper to prepare for multi-view (flutter/engine#52073) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
gilnobrega
pushed a commit
to gilnobrega/flutter
that referenced
this pull request
Apr 22, 2024
…lutter#146775) flutter/engine@1a13c7d...84238c4 2024-04-15 [email protected] [scenarios] test disabling surface clear. (flutter/engine#52128) 2024-04-12 [email protected] Roll Dart SDK from 3d13dbfb3284 to ac31be3c8546 (8 revisions) (flutter/engine#52084) 2024-04-12 [email protected] Roll Skia from 761f6f7f6250 to 9e20a146c024 (7 revisions) (flutter/engine#52085) 2024-04-12 [email protected] [Windows] Refactor client wrapper to prepare for multi-view (flutter/engine#52073) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I suspect that the change to clear the surface is the result of the scenario app instability. just a guess: the screenshots looks like we're missing the platform view. maybe the clearing of the surface is causing an extra frame to be pushed. That frame is getting picked up in the golden due to a race condition that is hard to hit locally
Testing disabling of this functionality in the golden test. If this pass a real fix involves some sort of hook into the rendering to verify it has fully completed before screenshotting.