Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[Impeller] Remove old clip height tracking from Entity. #52178

Merged
merged 3 commits into from
Apr 17, 2024

Conversation

bdero
Copy link
Member

@bdero bdero commented Apr 16, 2024

And rename clip depth accessors and members.

After this, I'm going to attempt to remove the need for tracking clip height altogether in EntityPass as well.

Copy link
Member

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RIP in peace

@bdero bdero merged commit ade5095 into flutter:main Apr 17, 2024
26 checks passed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 17, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 17, 2024
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Apr 17, 2024
…146946)

flutter/engine@cc73c5c...9edcb26

2024-04-17 [email protected] [Impeller] Delete `EntityPass::AddSubpassInline`. (flutter/engine#52182)
2024-04-17 [email protected] Roll Skia from 2790777048d3 to 0c56bd472923 (4 revisions) (flutter/engine#52203)
2024-04-17 [email protected] [macOS] Handle interleaved movement and gesture events (flutter/engine#52201)
2024-04-17 [email protected] [Impeller] Remove old clip height tracking from Entity. (flutter/engine#52178)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
gilnobrega pushed a commit to gilnobrega/flutter that referenced this pull request Apr 22, 2024
…lutter#146946)

flutter/engine@cc73c5c...9edcb26

2024-04-17 [email protected] [Impeller] Delete `EntityPass::AddSubpassInline`. (flutter/engine#52182)
2024-04-17 [email protected] Roll Skia from 2790777048d3 to 0c56bd472923 (4 revisions) (flutter/engine#52203)
2024-04-17 [email protected] [macOS] Handle interleaved movement and gesture events (flutter/engine#52201)
2024-04-17 [email protected] [Impeller] Remove old clip height tracking from Entity. (flutter/engine#52178)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants