This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[web:tests] switch to new HTML DOM matcher #52354
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the over-architected and under-utilized
canonicalizeHtml
andHtmlComparisonMode
. Replace with a newhasHtml
matcher.The new matcher produces considerably better error messages when matching fails (see
matchers_test.dart
for multiple examples). It also allows focusing on particular parts of the DOM rather than looking for a full match. This way a test can test just the functionality it cares about, and it can skip specifying what unrelated parts should look like (i.e. it prevents over-testing). For example, let's say you want to test that an<flt-semantics>
element has anaria-label
attribute. You can use a DOM pattern that specified just that:This will check for the existence of
<flt-semantics>
andaria-label="hello"
. It will ignore everything else that's unrelated to ARIA labels. For example, the element may have its geometry specified in thestyle
attribute, anid
attribute, and many other things, but if the test doesn't care, it doesn't need to specify those things (it can, if needs to though). This also applies tostyle
properties. See more examples in thematchers_test.dart
file.