This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Impeller] initialize ahb swapchain with max entries. #52670
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@test-exemption-reviewer" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
chinmaygarde
reviewed
May 8, 2024
| @@ -281,6 +281,9 @@ static TextureDescriptor ToTextureDescriptor( | |||
| desc.mip_count = (ahb_desc.usage & AHARDWAREBUFFER_USAGE_GPU_MIPMAP_COMPLETE) | |||
| ? ahb_size.MipCount() | |||
| : 1u; | |||
| if (ahb_desc.usage & AHARDWAREBUFFER_USAGE_COMPOSER_OVERLAY) { | |||
There was a problem hiding this comment.
There is also AHARDWAREBUFFER_USAGE_GPU_FRAMEBUFFER. I think this whole method could do a redo to to account for accurate usage. I'll patch it up later.
chinmaygarde
approved these changes
May 8, 2024
jonahwilliams
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 9, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
May 9, 2024
…148030) flutter/engine@bd58d2b...69f2d96 2024-05-08 [email protected] Roll Skia from 4e83fac12783 to 91088addfbd9 (1 revision) (flutter/engine#52691) 2024-05-08 [email protected] Roll Skia from df446841e3cd to 4e83fac12783 (2 revisions) (flutter/engine#52688) 2024-05-08 [email protected] Fix UIVisualEffectView leak in platform view filter (flutter/engine#52591) 2024-05-08 [email protected] [Impeller] initialize ahb swapchain with max entries. (flutter/engine#52670) 2024-05-08 [email protected] Roll Skia from 76f88de905be to df446841e3cd (3 revisions) (flutter/engine#52686) 2024-05-08 [email protected] Reland "Add host_profile_arm64 and host_release_arm64 local engine configurations." (flutter/engine#52633) 2024-05-08 [email protected] Roll Fuchsia Linux SDK from 27ZAbzJkEopmu0Emp... to RDVdjRvCxkJh2NLxS... (flutter/engine#52685) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from 27ZAbzJkEopm to RDVdjRvCxkJh If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The regression on the complex layout app is due to lazily constructing the AHBs on the first few frames:
https://flutter-flutter-perf.skia.org/e/?begin=1712175722&end=1715166324&queries=device_type%3DPixel_7_Pro%26sub_result%3D90th_percentile_frame_rasterizer_time_millis%26sub_result%3D99th_percentile_frame_rasterizer_time_millis%26sub_result%3Daverage_frame_rasterizer_time_millis%26sub_result%3Dworst_frame_rasterizer_time_millis%26test%3Dcomplex_layout_scroll_perf_impeller__timeline_summary&requestType=0&selected=commit%3D40701%26name%3D%252Carch%253Dintel%252Cbranch%253Dmaster%252Cconfig%253Ddefault%252Cdevice_type%253DPixel_7_Pro%252Cdevice_version%253Dnone%252Chost_type%253Dlinux%252Csub_result%253Dworst_frame_rasterizer_time_millis%252Ctest%253Dcomplex_layout_scroll_perf_impeller__timeline_summary%252C
Lets try eager initialization like the KHR swapchain does.