Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[semantics] fix dartdoc grammar #53121

Merged
merged 1 commit into from
May 30, 2024
Merged

Conversation

yjbanov
Copy link
Contributor

@yjbanov yjbanov commented May 30, 2024

Courtesy of @gspencergoog: "which widget" is korrecter than "what widget".

@yjbanov yjbanov requested a review from gspencergoog May 30, 2024 17:21
Copy link
Contributor

@gspencergoog gspencergoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

32384589-a60f0e74-c078-11e7-9bc1-e5b5287aea9d

@yjbanov yjbanov added the autosubmit Merge PR when tree becomes green via auto submit App label May 30, 2024
@auto-submit auto-submit bot merged commit 4956e98 into flutter:main May 30, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 30, 2024
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request May 31, 2024
…149367)

flutter/engine@bf2e32d...4956e98

2024-05-30 [email protected] [semantics] fix dartdoc grammar (flutter/engine#53121)
2024-05-30 [email protected] Roll Skia from 188ad395c3e7 to a058f601e1fb (1 revision) (flutter/engine#53131)
2024-05-30 [email protected] Replace several NSAssert with FML_CHECK/DCHECK to unblock the build (flutter/engine#53048)
2024-05-30 [email protected] [Impeller] make sure buffers are 4 aligned for foreground color blending (flutter/engine#53077)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
victorsanni pushed a commit to victorsanni/flutter that referenced this pull request May 31, 2024
…lutter#149367)

flutter/engine@bf2e32d...4956e98

2024-05-30 [email protected] [semantics] fix dartdoc grammar (flutter/engine#53121)
2024-05-30 [email protected] Roll Skia from 188ad395c3e7 to a058f601e1fb (1 revision) (flutter/engine#53131)
2024-05-30 [email protected] Replace several NSAssert with FML_CHECK/DCHECK to unblock the build (flutter/engine#53048)
2024-05-30 [email protected] [Impeller] make sure buffers are 4 aligned for foreground color blending (flutter/engine#53077)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
autosubmit Merge PR when tree becomes green via auto submit App
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants