This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Fix #150515 Provide required headers for build with Clang-16 and GCC … #53479
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…14 C++Stdlib backend.
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@test-exemption-reviewer" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
chinmaygarde
approved these changes
Jun 27, 2024
jason-simmons
approved these changes
Jun 27, 2024
chinmaygarde
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 27, 2024
…Clang-16 and GCC … (flutter/engine#53479)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 27, 2024
…Clang-16 and GCC … (flutter/engine#53479)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 27, 2024
…Clang-16 and GCC … (flutter/engine#53479)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 27, 2024
…Clang-16 and GCC … (flutter/engine#53479)
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jun 28, 2024
…150968) flutter/engine@ddd4814...94591ff 2024-06-27 [email protected] Roll Skia from cbd6e55139ca to 1700e3962acd (2 revisions) (flutter/engine#53619) 2024-06-27 [email protected] Roll Dart SDK from b5f079c2936e to e7022f6eb6c9 (1 revision) (flutter/engine#53616) 2024-06-27 [email protected] Update DEPS to pull in 8c2d66fa4e6298894425f5bdd0591bc5b1154c53. (flutter/engine#53614) 2024-06-27 [email protected] Roll Skia from c73e514838b4 to cbd6e55139ca (4 revisions) (flutter/engine#53615) 2024-06-27 [email protected] Fix #150515 Provide required headers for build with Clang-16 and GCC â�¦ (flutter/engine#53479) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
victorsanni
pushed a commit
to victorsanni/flutter
that referenced
this pull request
Jul 8, 2024
…lutter#150968) flutter/engine@ddd4814...94591ff 2024-06-27 [email protected] Roll Skia from cbd6e55139ca to 1700e3962acd (2 revisions) (flutter/engine#53619) 2024-06-27 [email protected] Roll Dart SDK from b5f079c2936e to e7022f6eb6c9 (1 revision) (flutter/engine#53616) 2024-06-27 [email protected] Update DEPS to pull in 8c2d66fa4e6298894425f5bdd0591bc5b1154c53. (flutter/engine#53614) 2024-06-27 [email protected] Roll Skia from c73e514838b4 to cbd6e55139ca (4 revisions) (flutter/engine#53615) 2024-06-27 [email protected] Fix flutter#150515 Provide required headers for build with Clang-16 and GCC â�¦ (flutter/engine#53479) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Impeller engine build with
clang-16and GCC 14 C++Stdlib does not implicitly include<algorithm>.Fixes issue: #150515
If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.