This repository was archived by the owner on Feb 25, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6k
Reverts "Fix focus management for text fields (#51009)" #53502
Merged
auto-submit
merged 1 commit into
main
from
revert_87a632b43536cee9df3e17c59b86c2dff077fcee
Jun 21, 2024
Merged
Reverts "Fix focus management for text fields (#51009)" #53502
auto-submit
merged 1 commit into
main
from
revert_87a632b43536cee9df3e17c59b86c2dff077fcee
Jun 21, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 87a632b.
fluttergithubbot
approved these changes
Jun 21, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 21, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 21, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 21, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 21, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jun 21, 2024
…150637) flutter/engine@dda82d9...33415c6 2024-06-21 [email protected] Roll Dart SDK from 4483d67ba725 to fc1e5912fc94 (1 revision) (flutter/engine#53503) 2024-06-21 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Fix focus management for text fields (#51009)" (flutter/engine#53502) 2024-06-21 [email protected] Roll Dart SDK from 19d3e659f49a to 4483d67ba725 (2 revisions) (flutter/engine#53501) 2024-06-20 [email protected] [web] Add 'flt-semantics-identifier' attribute to semantics nodes (flutter/engine#53278) 2024-06-20 [email protected] [web] Don't add `href="#"` to semantics links (flutter/engine#53395) 2024-06-20 [email protected] Roll Dart SDK from be6b533e07e7 to 19d3e659f49a (1 revision) (flutter/engine#53495) 2024-06-20 [email protected] Roll Fuchsia Linux SDK from tD5pof7jVnbXPwP7l... to iU-B6rJxy0wUYSmmp... (flutter/engine#53493) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from tD5pof7jVnbX to iU-B6rJxy0wU If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
ditman
added a commit
to ditman/flutter-engine
that referenced
this pull request
Jun 24, 2024
This reverts commit cf3ac2d (flutter#53502).
8 tasks
auto-submit bot
pushed a commit
that referenced
this pull request
Jun 24, 2024
Relands: [**Fix focus management for text fields** (#51009)](#51009) by: * Reverting commit: cf3ac2d (#53502). * Keeping the new `ViewFocusBinding` disabled, as [suggested](#51009 (comment)). [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
sigurdm
pushed a commit
to sigurdm/flutter
that referenced
this pull request
Jun 26, 2024
…lutter#150637) flutter/engine@dda82d9...33415c6 2024-06-21 [email protected] Roll Dart SDK from 4483d67ba725 to fc1e5912fc94 (1 revision) (flutter/engine#53503) 2024-06-21 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Fix focus management for text fields (flutter#51009)" (flutter/engine#53502) 2024-06-21 [email protected] Roll Dart SDK from 19d3e659f49a to 4483d67ba725 (2 revisions) (flutter/engine#53501) 2024-06-20 [email protected] [web] Add 'flt-semantics-identifier' attribute to semantics nodes (flutter/engine#53278) 2024-06-20 [email protected] [web] Don't add `href="#"` to semantics links (flutter/engine#53395) 2024-06-20 [email protected] Roll Dart SDK from be6b533e07e7 to 19d3e659f49a (1 revision) (flutter/engine#53495) 2024-06-20 [email protected] Roll Fuchsia Linux SDK from tD5pof7jVnbXPwP7l... to iU-B6rJxy0wUYSmmp... (flutter/engine#53493) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from tD5pof7jVnbX to iU-B6rJxy0wU If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
platform-web
Code specifically for the web engine
revert of
Bot Only: Tracking label for bot. Tracks new revert of pull requests.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts: #51009
Initiated by: jiahaog
Reason for reverting: This causes b/348598454. We're getting test failures with stack traces like the following after this PR:
Original PR Author: tugorez
Reviewed By: {mdebbar}
This change reverts the following previous change:
Fix focus management for text fields
This PR:
focus
function to take optionsactiveDomElement.focus()
so that the input elements get focused as immediate as possible.requestViewFocusChange
to claim focus in that view after some time. This gives2
the opportunity to focus the right<input />
or<textarea />
element. This helps focus correctly transition from one input element to another (without jumping to a flutter view in between).TextField
doesn't blur the focused element anymore, it insteads schedules for later a call to move the focus to the flutter view if nothing inside it claimed focus first.Sample apps
Pre-launch Checklist
///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.