This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[web] Implement AppLifecycleState.detached as documented
#53506
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ditman
reviewed
Jun 21, 2024
ditman
approved these changes
Jun 22, 2024
ditman
reviewed
Jun 22, 2024
lib/web_ui/test/engine/platform_dispatcher/app_lifecycle_state_test.dart
Outdated
Show resolved
Hide resolved
mdebbar
added
the
autosubmit
|
Is this fix going to be cherry-picked for the next hotfix? |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 25, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jun 25, 2024
…150781) flutter/engine@fbd9205...6313b1e 2024-06-25 [email protected] [web] Implement `AppLifecycleState.detached` as documented (flutter/engine#53506) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
|
I'm eagerly waiting for this, as the current stable version 3.22.2 is rendering my application useless in some user cases (no new frames with active and visible application). |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, we are transitioning to the
AppLifecycleState.detachedincorrectly. This is causing the framework to stop pumping frames when the app is still active and visible.This PR re-implements the transition to
AppLifecycleState.detachedas documented here (based on whether the app has any views or not).Fixes flutter/flutter#150636
Fixes flutter/flutter#149417