Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

gmackall
Copy link
Member

@gmackall gmackall commented Jul 15, 2024

See flutter/flutter#83596 (comment), there are two cases:

  1. IO issue
  2. The directory doesn't exist

Narrow down by including in the logs if the directory exists or not.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Gray Mackall added 2 commits July 15, 2024 15:40
@gmackall gmackall requested a review from a team July 15, 2024 22:42
@gmackall gmackall marked this pull request as ready for review July 15, 2024 22:42
@flutter-dashboard

This comment was marked as resolved.

Gray Mackall added 2 commits July 16, 2024 11:10
@gmackall gmackall added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 16, 2024
@auto-submit auto-submit bot merged commit e5215e6 into flutter:main Jul 16, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 16, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 16, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 16, 2024
zanderso pushed a commit to flutter/flutter that referenced this pull request Jul 17, 2024
…151863)

flutter/engine@475980e...5b9fc4e

2024-07-16 [email protected] [iOS] Delete gen_snapshot_armv7 support
(flutter/engine#53947)
2024-07-16 [email protected] Roll Skia from f9422e08a793 to
d1478885de20 (3 revisions) (flutter/engine#53946)
2024-07-16 [email protected] [web] fix unexpected scrolling in
semantics (flutter/engine#53922)
2024-07-16 [email protected] More logs for
Android unsatisfiedLinkError (flutter/engine#53920)
2024-07-16 [email protected] Roll Skia from 9b789b35e109 to
f9422e08a793 (1 revision) (flutter/engine#53944)
2024-07-16 [email protected] Roll Fuchsia Linux SDK from
VlZIUknh6dnA23owe... to C_ze_BbJWtfB9GdOA... (flutter/engine#53941)
2024-07-16 [email protected] Roll Skia from a6ac2f8e82b4 to
9b789b35e109 (1 revision) (flutter/engine#53942)
2024-07-16 [email protected] Roll Skia from 57ae89c0ffae to
a6ac2f8e82b4 (1 revision) (flutter/engine#53940)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from VlZIUknh6dnA to C_ze_BbJWtfB

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that
a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
TytaniumDev pushed a commit to TytaniumDev/flutter that referenced this pull request Aug 7, 2024
…lutter#151863)

flutter/engine@475980e...5b9fc4e

2024-07-16 [email protected] [iOS] Delete gen_snapshot_armv7 support
(flutter/engine#53947)
2024-07-16 [email protected] Roll Skia from f9422e08a793 to
d1478885de20 (3 revisions) (flutter/engine#53946)
2024-07-16 [email protected] [web] fix unexpected scrolling in
semantics (flutter/engine#53922)
2024-07-16 [email protected] More logs for
Android unsatisfiedLinkError (flutter/engine#53920)
2024-07-16 [email protected] Roll Skia from 9b789b35e109 to
f9422e08a793 (1 revision) (flutter/engine#53944)
2024-07-16 [email protected] Roll Fuchsia Linux SDK from
VlZIUknh6dnA23owe... to C_ze_BbJWtfB9GdOA... (flutter/engine#53941)
2024-07-16 [email protected] Roll Skia from a6ac2f8e82b4 to
9b789b35e109 (1 revision) (flutter/engine#53942)
2024-07-16 [email protected] Roll Skia from 57ae89c0ffae to
a6ac2f8e82b4 (1 revision) (flutter/engine#53940)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from VlZIUknh6dnA to C_ze_BbJWtfB

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that
a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Buchimi pushed a commit to Buchimi/flutter that referenced this pull request Sep 2, 2024
…lutter#151863)

flutter/engine@475980e...5b9fc4e

2024-07-16 [email protected] [iOS] Delete gen_snapshot_armv7 support
(flutter/engine#53947)
2024-07-16 [email protected] Roll Skia from f9422e08a793 to
d1478885de20 (3 revisions) (flutter/engine#53946)
2024-07-16 [email protected] [web] fix unexpected scrolling in
semantics (flutter/engine#53922)
2024-07-16 [email protected] More logs for
Android unsatisfiedLinkError (flutter/engine#53920)
2024-07-16 [email protected] Roll Skia from 9b789b35e109 to
f9422e08a793 (1 revision) (flutter/engine#53944)
2024-07-16 [email protected] Roll Fuchsia Linux SDK from
VlZIUknh6dnA23owe... to C_ze_BbJWtfB9GdOA... (flutter/engine#53941)
2024-07-16 [email protected] Roll Skia from a6ac2f8e82b4 to
9b789b35e109 (1 revision) (flutter/engine#53942)
2024-07-16 [email protected] Roll Skia from 57ae89c0ffae to
a6ac2f8e82b4 (1 revision) (flutter/engine#53940)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from VlZIUknh6dnA to C_ze_BbJWtfB

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that
a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

autosubmit Merge PR when tree becomes green via auto submit App platform-android

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants