This repository was archived by the owner on Feb 25, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6k
Rename FlBackingStoreProvider to FlFramebuffer #54047
Merged
robert-ancell
merged 1 commit into
flutter:main
from
robert-ancell:linux-rename-backing-store-class
Jul 24, 2024
Merged
Rename FlBackingStoreProvider to FlFramebuffer #54047
robert-ancell
merged 1 commit into
flutter:main
from
robert-ancell:linux-rename-backing-store-class
Jul 24, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0698c82
to
123d9e9
Compare
The name was confusing, as it only provided one type of backing store. FlBackingStoreProvider sounds more like an interface that the FlFramebuffer would implement if we had multiple backing stores. Use OpenGL types for values. Fix cases where this was sometimes called a texture. Improve documentation. Remove the use of GdkRectangle for dimensions - the framebuffer only has a width and a height. There was code that was using the x,y values which would always have been zero - this has now been removed.
123d9e9
to
ea61968
Compare
cbracken
approved these changes
Jul 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A bit puzzled because the failure here is a mac host build failure:
|
A number of builds today have had mac failures. I guess we ignore them? |
I would try rebasing to tip of tree in case this was a bad commit that was reverted. This looks nearby to code I changed a week ago, but would be strange if it only started breaking as a delayed time bomb. The engine tree seems green right now. I'll kick off a re-run on that test to see what happens. The error doesn't seem like it would be a flake though. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 24, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jul 24, 2024
…152214) flutter/engine@0b13fa3...d3800a9 2024-07-24 [email protected] Rename FlBackingStoreProvider to FlFramebuffer (flutter/engine#54047) 2024-07-24 [email protected] Remove unnecessary double cast (flutter/engine#54044) 2024-07-24 [email protected] Fix variable name (flutter/engine#54045) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
TytaniumDev
pushed a commit
to TytaniumDev/flutter
that referenced
this pull request
Aug 7, 2024
…lutter#152214) flutter/engine@0b13fa3...d3800a9 2024-07-24 [email protected] Rename FlBackingStoreProvider to FlFramebuffer (flutter/engine#54047) 2024-07-24 [email protected] Remove unnecessary double cast (flutter/engine#54044) 2024-07-24 [email protected] Fix variable name (flutter/engine#54045) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Buchimi
pushed a commit
to Buchimi/flutter
that referenced
this pull request
Sep 2, 2024
…lutter#152214) flutter/engine@0b13fa3...d3800a9 2024-07-24 [email protected] Rename FlBackingStoreProvider to FlFramebuffer (flutter/engine#54047) 2024-07-24 [email protected] Remove unnecessary double cast (flutter/engine#54044) 2024-07-24 [email protected] Fix variable name (flutter/engine#54045) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The name was confusing, as it only provided one type of backing store. FlBackingStoreProvider sounds more like an interface that the FlFramebuffer would implement if we had multiple backing stores.
Use OpenGL types for values.
Fix cases where this was sometimes called a texture.
Improve documentation.
Remove the use of GdkRectangle for dimensions - the framebuffer only has a width and a height. There was code that was using the x,y values which would always have been zero - this has now been removed.
This should be test exempt as it is only a renaming and will be covered by existing tests.