Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

itsjustkevin
Copy link
Contributor

Manual roll requested by [email protected]

https://dart.googlesource.com/sdk.git/+log/44635f897535..8c02ad43e01a

2024-08-14 [email protected] Version 3.6.0-149.0.dev
2024-08-13 [email protected] Version 3.6.0-148.0.dev
2024-08-13 [email protected] Version 3.6.0-147.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

skia-flutter-autoroll and others added 6 commits August 14, 2024 21:12
Manual roll requested by [email protected]

https://dart.googlesource.com/sdk.git/+log/44635f897535..790fcb755a0a

2024-08-14 [email protected] Version 3.6.0-149.0.dev
2024-08-13 [email protected] Version 3.6.0-148.0.dev
2024-08-13 [email protected] Version 3.6.0-147.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group.

@itsjustkevin itsjustkevin requested a review from zanderso August 16, 2024 16:23
@itsjustkevin itsjustkevin added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 16, 2024
@auto-submit auto-submit bot merged commit 0e70fc3 into flutter:main Aug 16, 2024
33 checks passed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 16, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 16, 2024
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Aug 16, 2024
…153582)

flutter/engine@d5bf3af...b66893e

2024-08-16 [email protected] iOS: Add dSYM binaries to without_entitlements.txt (flutter/engine#54576)
2024-08-16 [email protected] Manual roll Dart SDK from 44635f897535 to 8c02ad43e01a (3 revisions)  (flutter/engine#54581)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Buchimi pushed a commit to Buchimi/flutter that referenced this pull request Sep 2, 2024
…lutter#153582)

flutter/engine@d5bf3af...b66893e

2024-08-16 [email protected] iOS: Add dSYM binaries to without_entitlements.txt (flutter/engine#54576)
2024-08-16 [email protected] Manual roll Dart SDK from 44635f897535 to 8c02ad43e01a (3 revisions)  (flutter/engine#54581)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
autosubmit Merge PR when tree becomes green via auto submit App
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants