This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Use GNI group instead of hardcoding PNG codecs source files. #54781
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hubot
pushed a commit
to google/skia
that referenced
this pull request
Aug 26, 2024
This reverts commit eb5f21e. This reland is possible, because Flutter issues have been addressed by flutter/engine#54781 Original commit description: This CL extracts a minimal `SkPngCodecBase` - a common base class of `SkPngCodec` and `SkPngRustCodec` with functionality shared by both of these derived classes. Bug: chromium:356879515 Change-Id: I7e49e3d5ef07d2ea96cb445b524a798954beeba2 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/893460 Auto-Submit: Łukasz Anforowicz <[email protected]> Commit-Queue: Brian Osman <[email protected]> Reviewed-by: Brian Osman <[email protected]> Reviewed-by: Kaylee Lubick <[email protected]>
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 27, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Aug 27, 2024
…ions) (#154153) Manual roll requested by [email protected] flutter/engine@f645ca5...b41ca79 2024-08-26 [email protected] [Impeller] fix incorrect origins for mesh gradient computation. (flutter/engine#54762) 2024-08-26 [email protected] Change the `ci/analyze.sh` script to analyze _all_ of the engine (flutter/engine#54779) 2024-08-26 [email protected] Use GNI group instead of hardcoding PNG codecs source files. (flutter/engine#54781) 2024-08-26 [email protected] [ios] Fix text input edit rotor accessibility (flutter/engine#54351) 2024-08-26 [email protected] Ensure orchestrators aren't assigned to 32 core machines (flutter/engine#54754) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Buchimi
pushed a commit
to Buchimi/flutter
that referenced
this pull request
Sep 2, 2024
…ions) (flutter#154153) Manual roll requested by [email protected] flutter/engine@f645ca5...b41ca79 2024-08-26 [email protected] [Impeller] fix incorrect origins for mesh gradient computation. (flutter/engine#54762) 2024-08-26 [email protected] Change the `ci/analyze.sh` script to analyze _all_ of the engine (flutter/engine#54779) 2024-08-26 [email protected] Use GNI group instead of hardcoding PNG codecs source files. (flutter/engine#54781) 2024-08-26 [email protected] [ios] Fix text input edit rotor accessibility (flutter/engine#54351) 2024-08-26 [email protected] Ensure orchestrators aren't assigned to 32 core machines (flutter/engine#54754) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://issues.skia.org/issues/362267329. The indirection introduced by this PR insulates Flutter from source-file-list changes in Skia. See the linked bug for more details.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.