[Impeller] migrate last color wheel test to DisplayList. #54964
Conversation
|
Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change). If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review. |
|
If you notice on the goldens, the old vulkan and gles goldens were incorrect and not rendering properly. |
|
|
||
| BlendModeSelection blend_modes = GetBlendModeSelection(); | ||
|
|
||
| auto draw_color_wheel = [](DisplayListBuilder& builder) { |
There was a problem hiding this comment.
nit: Since we are using auto we should have explicit return types in the lamda declaration, especially since the return is so far away.
There was a problem hiding this comment.
Should that be done by making the auto explicit or by the lambda return specifier ->?
The -> format doesn't stand out very well for me, but it is more explicit than just declaring a type for the variable.
There was a problem hiding this comment.
Oh wait, the auto here is not the return value of the lambda function, it's the type of the lambda itself? In that case -> is much less disruptive.
There was a problem hiding this comment.
its a void function :)
jonahwilliams
added
the
autosubmit
…154679) flutter/engine@e042ff5...c50eb8a 2024-09-05 [email protected] [Impeller] migrate last color wheel test to DisplayList. (flutter/engine#54964) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Update last AIKS golden test.
Part of Part of flutter/flutter#142054