This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Migrate more tests from litetest to package:test
#55119
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matanlurey
changed the title
testing/dart/observatory to package:test.litetest to package:test
gaaclarke
reviewed
Sep 12, 2024
| @@ -402,22 +402,23 @@ void main() async { | |||
| path.join('supported_glsl_op_shaders', 'iplr'), | |||
| '.iplr', | |||
| ); | |||
| expect(iplrSupportedGLSLOpShaders.isNotEmpty, true); | |||
There was a problem hiding this comment.
Why are we losing these asserts? I see the print statement below, are we just going to fail further down in execution?
There was a problem hiding this comment.
Package test can't run assertions outside of a test block and these functions generate tests. I think the test will still fail approximately at the same time though?
There was a problem hiding this comment.
Changed to a fail
| } | ||
| }); | ||
| sendPort.send(recvPort.sendPort); | ||
| await completer.future; | ||
| recvPort.close(); | ||
| }); | ||
| expect(sum, 5500); // sum(1 to 10) * 100 |
There was a problem hiding this comment.
Please bring back this comment.
gaaclarke
approved these changes
Sep 12, 2024
testing/dart/canvas_test.dart
Outdated
|
|
||
| @override | ||
| Description describe(Description description) { | ||
| return description.add('Rect is close to $_expectedRect'); |
There was a problem hiding this comment.
nit: print out the limit, 1e-6
| }; | ||
|
|
||
| @override | ||
| Description describe(Description description) { |
matanlurey
added
the
autosubmit
|
auto label is removed for flutter/engine/55119, due to - The status or check suite Mac mac_unopt has failed. Please fix the issues identified (or deflake) before re-applying this label. |
auto-submit
bot
removed
the
autosubmit
matanlurey
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 12, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Sep 12, 2024
…155128) flutter/engine@48ddaf5...8609af6 2024-09-12 [email protected] Revert "Update Color to do all calculations with floating point components" (flutter/engine#55153) 2024-09-12 [email protected] Migrate more tests from `litetest` to `package:test` (flutter/engine#55119) 2024-09-12 [email protected] Roll Skia from acff7f24ddbe to 26b048c6a53b (1 revision) (flutter/engine#55151) 2024-09-12 [email protected] Roll Dart SDK from a438066d634f to aa27c61f5859 (8 revisions) (flutter/engine#55147) 2024-09-12 [email protected] Update Skia build for Vulkan headers (flutter/engine#55143) 2024-09-12 [email protected] Roll Skia from 2b40b50ea423 to acff7f24ddbe (1 revision) (flutter/engine#55144) 2024-09-12 [email protected] Update Color to do all calculations with floating point components (flutter/engine#54981) 2024-09-12 [email protected] Roll Fuchsia Linux SDK from fKNT8lbGh8JzxjE6m... to 3YH1DEYJ-s93fHBw5... (flutter/engine#55142) 2024-09-12 [email protected] Migrate `const_finder_test` to use `package:test` (flutter/engine#55132) 2024-09-12 [email protected] [engine] make UI thread the platform thread for Android. Still allows opt out as g3 escape hatch. (flutter/engine#55111) 2024-09-12 [email protected] Roll Skia from b750cbedc114 to 2b40b50ea423 (1 revision) (flutter/engine#55141) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from fKNT8lbGh8Jz to 3YH1DEYJ-s93 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partial work towards flutter/flutter#133569.
Commentary on removal of
assert-conditionals here: flutter/flutter#155054.