This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Impeller] libImpeller: Respect the paragraph style line height specification. #56066
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chinmaygarde
commented
Oct 23, 2024
| @@ -28,6 +28,7 @@ void ParagraphStyle::SetFontSize(double size) { | |||
|
|
|||
| void ParagraphStyle::SetHeight(double height) { | |||
| style_.height = height; | |||
| style_.has_height_override = (height != 0.0); | |||
There was a problem hiding this comment.
Not sure why this isn't an optional. There is also a similar pattern around struts.
chinmaygarde
added
the
autosubmit
|
auto label is removed for flutter/engine/56066, due to - The status or check suite Mac mac_unopt has failed. Please fix the issues identified (or deflake) before re-applying this label. |
auto-submit
bot
removed
the
autosubmit
chinmaygarde
force-pushed
the
lineheight
branch
from
f5bc0fa to
9ceed34
Compare
chinmaygarde
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 25, 2024
…ight specification. (flutter/engine#56066)
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Oct 25, 2024
…157572) flutter/engine@29440ed...b1c2ba8 2024-10-25 [email protected] [Impeller] libImpeller: Respect the paragraph style line height specification. (flutter/engine#56066) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
nick9822
pushed a commit
to nick9822/flutter
that referenced
this pull request
Dec 18, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @lyceel