-
Notifications
You must be signed in to change notification settings - Fork 6k
[macos] early return to suppress clang-tidy warning #56588
[macos] early return to suppress clang-tidy warning #56588
Conversation
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
shell/platform/darwin/macos/framework/Source/FlutterChannelKeyResponder.mm
Outdated
Show resolved
Hide resolved
shell/platform/darwin/macos/framework/Source/FlutterChannelKeyResponder.mm
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
…Responder.mm Co-authored-by: Chris Bracken <[email protected]>
test-exempt: Silence clang tidy, not a behavioral change. |
…159015) Roll Flutter Engine from 619804c0fbb7 to f649330affa8 (47 revisions) flutter/engine@619804c...f649330 2024-11-16 [email protected] Roll Skia from 1ef3b910e064 to 6b0f264bde33 (6 revisions) (flutter/engine#56635) 2024-11-16 [email protected] Revert "Remove `android_jit_release_x86`." (flutter/engine#56634) 2024-11-15 [email protected] Move SetRenderTargetType to EmbedderTestCompositor (flutter/engine#56626) 2024-11-15 [email protected] Roll Dart SDK from b62dadb14d82 to eccb15756020 (2 revisions) (flutter/engine#56630) 2024-11-15 [email protected] [TextInput] Add TextInputType.webSearch (#15762) (flutter/engine#56428) 2024-11-15 [email protected] [web] Send the correct view ID with semantics actions (flutter/engine#56595) 2024-11-15 [email protected] [macos] early return to suppress clang-tidy warning (flutter/engine#56588) 2024-11-15 [email protected] [Impeller] libImpeller: Tinker on the README to cross reference the SDK and the example. (flutter/engine#56623) 2024-11-15 [email protected] [fuchsia] MaybeRunInitialVsyncCallback should only called once (flutter/engine#56429) 2024-11-15 [email protected] Move mac clangd build from x64 to arm (flutter/engine#56567) 2024-11-15 [email protected] Added assert for opengles thread safety (flutter/engine#56585) 2024-11-15 [email protected] [Impeller] enable OpenGL fallback on Android. (flutter/engine#56591) 2024-11-15 [email protected] [Impeller] Maintain separate queues of GLES operations for each thread in the reactor (flutter/engine#56573) 2024-11-15 [email protected] Roll Dart SDK from abe86ca4eb01 to b62dadb14d82 (2 revisions) (flutter/engine#56615) 2024-11-15 [email protected] Roll Skia from b730eb340852 to 1ef3b910e064 (4 revisions) (flutter/engine#56613) 2024-11-15 [email protected] Roll Fuchsia Linux SDK from JkpuAsLzcmYLzf1iX... to UpSQzyXGUhMfedYIh... (flutter/engine#56611) 2024-11-15 [email protected] Roll Dart SDK from bf0eeb9d929c to abe86ca4eb01 (1 revision) (flutter/engine#56610) 2024-11-15 [email protected] Roll Skia from e5fda8472b21 to b730eb340852 (1 revision) (flutter/engine#56608) 2024-11-15 [email protected] Roll Skia from 8ff65da4b8bf to e5fda8472b21 (1 revision) (flutter/engine#56603) 2024-11-15 [email protected] Move TestMetalContext/Surface to testing namespace (flutter/engine#56602) 2024-11-15 [email protected] Roll Dart SDK from 343b9fc6eafe to bf0eeb9d929c (1 revision) (flutter/engine#56604) 2024-11-15 [email protected] [Impeller] Don't enable KHR_debug on Angle. (flutter/engine#56601) 2024-11-15 [email protected] [Impeller] libImpeller: Reset the GL state when transitioning control back to the embedder. (flutter/engine#56597) 2024-11-15 [email protected] Roll Skia from 8946ea477b42 to 8ff65da4b8bf (2 revisions) (flutter/engine#56600) 2024-11-14 [email protected] [Impeller] Put test components in the testing namespace. (flutter/engine#56594) 2024-11-14 [email protected] [Impeller] libImpeller: Add a warning about OpenGL state being trampled. (flutter/engine#56599) 2024-11-14 [email protected] Embedder: Refactor EmbedderConfigBuilder by backend (flutter/engine#56598) 2024-11-14 [email protected] Migrate Metal translation units to Obj-C++ (flutter/engine#56592) 2024-11-14 [email protected] Roll Dart SDK from db4d7d52db48 to 343b9fc6eafe (1 revision) (flutter/engine#56590) 2024-11-14 [email protected] iOS,macOS: Build/test test_metal_surface_unittests (flutter/engine#56586) 2024-11-14 [email protected] Roll Skia from 3222456e63dc to 8946ea477b42 (2 revisions) (flutter/engine#56587) 2024-11-14 [email protected] Roll Skia from 16178bf63de7 to 3222456e63dc (3 revisions) (flutter/engine#56584) 2024-11-14 [email protected] [Android] Fix Slider semantics double tap behaviors (flutter/engine#56452) 2024-11-14 [email protected] Roll Dart SDK from a3b6652100c8 to db4d7d52db48 (1 revision) (flutter/engine#56581) 2024-11-14 [email protected] Move Vulkan context to EmbedderTestContextVulkan (flutter/engine#56571) 2024-11-14 [email protected] Roll Skia from a076435073fc to 16178bf63de7 (1 revision) (flutter/engine#56579) 2024-11-14 [email protected] Roll Skia from 70553189e4e8 to a076435073fc (1 revision) (flutter/engine#56577) 2024-11-14 [email protected] Roll Skia from fa52f2c1ddba to 70553189e4e8 (1 revision) (flutter/engine#56576) 2024-11-14 [email protected] Roll Dart SDK from 3f05b3540cb2 to a3b6652100c8 (3 revisions) (flutter/engine#56575) 2024-11-14 [email protected] Roll Skia from ddbd8d1cb8d8 to fa52f2c1ddba (3 revisions) (flutter/engine#56574) 2024-11-14 [email protected] [Android] choose 24 bit depth buffer. (flutter/engine#56553) 2024-11-14 [email protected] Roll Skia from 3750b8939c7f to ddbd8d1cb8d8 (1 revision) (flutter/engine#56562) 2024-11-14 [email protected] Move FlMouseCursorHandler from FlView to FlEngine (flutter/engine#56026) 2024-11-14 [email protected] [Impeller] force software resize usage for GLES backend. (flutter/engine#56511) 2024-11-14 [email protected] Roll Dart SDK from 66ab1774bfe9 to 3f05b3540cb2 (2 revisions) (flutter/engine#56564) 2024-11-14 [email protected] Embedder: Refactor EmbedderTestContext creation (flutter/engine#56563) ...
…6588) If we disable the NSAssert during release mode, this code will continue after NSAssert failure, which will then pass a `nil` value into a dictionary (which cannot have a nil value), hence the clang-tidy warning here flutter/engine#53005 (comment) *List which issues are fixed by this PR. You must list at least one issue.* flutter#148279 flutter#157837 *If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].* [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
If we disable the NSAssert during release mode, this code will continue after NSAssert failure, which will then pass a
nil
value into a dictionary (which cannot have a nil value), hence the clang-tidy warning here #53005 (comment)List which issues are fixed by this PR. You must list at least one issue.
flutter/flutter#148279
flutter/flutter#157837
If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.
Pre-launch Checklist
///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.