Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Replace Java code with equivalent, more concise code. #7398

Merged
merged 1 commit into from
Jan 7, 2019
Merged

Replace Java code with equivalent, more concise code. #7398

merged 1 commit into from
Jan 7, 2019

Conversation

tvolkert
Copy link
Contributor

@tvolkert tvolkert commented Jan 7, 2019

No description provided.

@tvolkert tvolkert requested a review from sbaranov January 7, 2019 18:59
sbaranov
sbaranov approved these changes Jan 7, 2019
View reviewed changes
Copy link
Contributor

@sbaranov sbaranov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@tvolkert tvolkert merged commit 4487d39 into flutter:master Jan 7, 2019
@tvolkert tvolkert deleted the klippy branch January 7, 2019 19:28
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 7, 2019
@engine-flutter-autoroll
4487d39 Replace Java code with equivalent, more concise code. (flutte…
d2b2be7 
…r/engine#7398)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 7, 2019
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 7, 2019
@engine-flutter-autoroll
4487d39 Replace Java code with equivalent, more concise code. (flutte…
8a16ef3 
…r/engine#7398)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 7, 2019
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 7, 2019
@engine-flutter-autoroll
4487d39 Replace Java code with equivalent, more concise code. (flutte…
77dc2c0 
…r/engine#7398)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 7, 2019
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 8, 2019
@engine-flutter-autoroll
4487d39 Replace Java code with equivalent, more concise code. (flutte…
468ea62 
…r/engine#7398)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 8, 2019
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 8, 2019
@engine-flutter-autoroll
4487d39 Replace Java code with equivalent, more concise code. (flutte…
b4a1a7c 
…r/engine#7398)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 8, 2019
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 8, 2019
@engine-flutter-autoroll
4487d39 Replace Java code with equivalent, more concise code. (flutte…
c4b8ccb 
…r/engine#7398)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 8, 2019
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 8, 2019
@engine-flutter-autoroll
4487d39 Replace Java code with equivalent, more concise code. (flutte…
e959f65 
…r/engine#7398)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 8, 2019
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 8, 2019
@engine-flutter-autoroll
4487d39 Replace Java code with equivalent, more concise code. (flutte…
4fd1332 
…r/engine#7398)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 8, 2019
Closed
bkonyi added a commit to flutter/flutter that referenced this pull request Jan 8, 2019
@bkonyi
Manual engine roll with fixes:
128f16f 
flutter/engine@7112b72...e5ec3cf

git log
7112b72..e5ec3cf
--no-merges --oneline
e5ec3cf Dart SDK roll for 2019-01-08
08c95d2 Roll src/third_party/skia 55ff5d3ba881..1337f5b85978 (10
commits) (flutter/engine#7407)
e385f5c Roll src/third_party/skia 26d173fee72b..55ff5d3ba881 (12
commits) (flutter/engine#7406)
0f8273b Dart SDK roll for 2019-01-07
4036b26 Reset ParagraphBuilder after build() (flutter/engine#7401)
4820cbe Dart SDK roll for 2019-01-07
8eccb86 Add onStart hook to FlutterFragmentActivity
(flutter/engine#6719)
f2ea838 Roll src/third_party/skia b2fdcbf3033f..26d173fee72b (10
commits) (flutter/engine#7400)
5ca8aad Announce in/out of list (flutter/engine#6918)
4487d39 Replace Java code with equivalent, more concise code.
(flutter/engine#7398)
395b785 Roll src/third_party/skia 46ee3f7a8ff5..b2fdcbf3033f (11
commits) (flutter/engine#7394)
5965f90 Make `ParagraphConstraints` have const constructor
(flutter/engine#7346)
e02dd41 Roll src/third_party/skia a47eb455360f..46ee3f7a8ff5 (2
commits) (flutter/engine#7390)
f0038b3 Roll src/third_party/skia 3ac3a4053f86..a47eb455360f (2
commits) (flutter/engine#7389)
@bkonyi bkonyi mentioned this pull request Jan 8, 2019
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 8, 2019
@engine-flutter-autoroll
4487d39 Replace Java code with equivalent, more concise code. (flutte…
c78e670 
…r/engine#7398)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 8, 2019
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 8, 2019
@engine-flutter-autoroll
4487d39 Replace Java code with equivalent, more concise code. (flutte…
f5e1df7 
…r/engine#7398)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 8, 2019
Closed
bkonyi added a commit to flutter/flutter that referenced this pull request Jan 9, 2019
@bkonyi
Manual engine roll with fixes: (#26252)
6412f35 
flutter/engine@7112b72...e5ec3cf

git log
7112b72..e5ec3cf
--no-merges --oneline
e5ec3cf Dart SDK roll for 2019-01-08
08c95d2 Roll src/third_party/skia 55ff5d3ba881..1337f5b85978 (10
commits) (flutter/engine#7407)
e385f5c Roll src/third_party/skia 26d173fee72b..55ff5d3ba881 (12
commits) (flutter/engine#7406)
0f8273b Dart SDK roll for 2019-01-07
4036b26 Reset ParagraphBuilder after build() (flutter/engine#7401)
4820cbe Dart SDK roll for 2019-01-07
8eccb86 Add onStart hook to FlutterFragmentActivity
(flutter/engine#6719)
f2ea838 Roll src/third_party/skia b2fdcbf3033f..26d173fee72b (10
commits) (flutter/engine#7400)
5ca8aad Announce in/out of list (flutter/engine#6918)
4487d39 Replace Java code with equivalent, more concise code.
(flutter/engine#7398)
395b785 Roll src/third_party/skia 46ee3f7a8ff5..b2fdcbf3033f (11
commits) (flutter/engine#7394)
5965f90 Make `ParagraphConstraints` have const constructor
(flutter/engine#7346)
e02dd41 Roll src/third_party/skia a47eb455360f..46ee3f7a8ff5 (2
commits) (flutter/engine#7390)
f0038b3 Roll src/third_party/skia 3ac3a4053f86..a47eb455360f (2
commits) (flutter/engine#7389)
@cbracken cbracken mentioned this pull request Jan 9, 2019
Merged
cbracken added a commit that referenced this pull request Jan 9, 2019
@cbracken
Eliminate unused import of ZipException (#7429)
20d70d2 
Use of this class was eliminated in #7398.
gamebox pushed a commit to gamebox/flutter that referenced this pull request Jan 28, 2019
@bkonyi @gamebox
Manual engine roll with fixes: (flutter#26252)
2f6d58c 
flutter/engine@7112b72...e5ec3cf

git log
7112b72..e5ec3cf
--no-merges --oneline
e5ec3cf Dart SDK roll for 2019-01-08
08c95d2 Roll src/third_party/skia 55ff5d3ba881..1337f5b85978 (10
commits) (flutter/engine#7407)
e385f5c Roll src/third_party/skia 26d173fee72b..55ff5d3ba881 (12
commits) (flutter/engine#7406)
0f8273b Dart SDK roll for 2019-01-07
4036b26 Reset ParagraphBuilder after build() (flutter/engine#7401)
4820cbe Dart SDK roll for 2019-01-07
8eccb86 Add onStart hook to FlutterFragmentActivity
(flutter/engine#6719)
f2ea838 Roll src/third_party/skia b2fdcbf3033f..26d173fee72b (10
commits) (flutter/engine#7400)
5ca8aad Announce in/out of list (flutter/engine#6918)
4487d39 Replace Java code with equivalent, more concise code.
(flutter/engine#7398)
395b785 Roll src/third_party/skia 46ee3f7a8ff5..b2fdcbf3033f (11
commits) (flutter/engine#7394)
5965f90 Make `ParagraphConstraints` have const constructor
(flutter/engine#7346)
e02dd41 Roll src/third_party/skia a47eb455360f..46ee3f7a8ff5 (2
commits) (flutter/engine#7390)
f0038b3 Roll src/third_party/skia 3ac3a4053f86..a47eb455360f (2
commits) (flutter/engine#7389)
kangwang1988 pushed a commit to XianyuTech/flutter that referenced this pull request Feb 12, 2019
@bkonyi @kangwang1988
Manual engine roll with fixes: (flutter#26252)
9ebf4c0 
flutter/engine@7112b72...e5ec3cf

git log
7112b72..e5ec3cf
--no-merges --oneline
e5ec3cf Dart SDK roll for 2019-01-08
08c95d2 Roll src/third_party/skia 55ff5d3ba881..1337f5b85978 (10
commits) (flutter/engine#7407)
e385f5c Roll src/third_party/skia 26d173fee72b..55ff5d3ba881 (12
commits) (flutter/engine#7406)
0f8273b Dart SDK roll for 2019-01-07
4036b26 Reset ParagraphBuilder after build() (flutter/engine#7401)
4820cbe Dart SDK roll for 2019-01-07
8eccb86 Add onStart hook to FlutterFragmentActivity
(flutter/engine#6719)
f2ea838 Roll src/third_party/skia b2fdcbf3033f..26d173fee72b (10
commits) (flutter/engine#7400)
5ca8aad Announce in/out of list (flutter/engine#6918)
4487d39 Replace Java code with equivalent, more concise code.
(flutter/engine#7398)
395b785 Roll src/third_party/skia 46ee3f7a8ff5..b2fdcbf3033f (11
commits) (flutter/engine#7394)
5965f90 Make `ParagraphConstraints` have const constructor
(flutter/engine#7346)
e02dd41 Roll src/third_party/skia a47eb455360f..46ee3f7a8ff5 (2
commits) (flutter/engine#7390)
f0038b3 Roll src/third_party/skia 3ac3a4053f86..a47eb455360f (2
commits) (flutter/engine#7389)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
1 more reviewer

@sbaranov sbaranov sbaranov approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tvolkert @sbaranov @googlebot