Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Improve 404 handling when downloading dynamic patches. #7432

Merged
merged 1 commit into from
Jan 10, 2019
Merged

Improve 404 handling when downloading dynamic patches. #7432

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 15 additions & 18 deletions shell/platform/android/io/flutter/view/ResourceUpdater.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,26 +104,23 @@ protected Void doInBackground(String... unused) {
connection.setIfModifiedSince(lastDownloadTime);
}

try (InputStream input = connection.getInputStream()) {
URL resolvedURL = connection.getURL();
Log.i(TAG, "Resolved update URL " + resolvedURL);

if (connection.getResponseCode() == HttpURLConnection.HTTP_NOT_FOUND) {
if (resolvedURL.equals(unresolvedURL)) {
Log.i(TAG, "Rolled back all updates");
localFile.delete();
return null;
} else {
Log.i(TAG, "Latest update not found");
return null;
}
}
URL resolvedURL = connection.getURL();
Log.i(TAG, "Resolved update URL " + resolvedURL);

if (connection.getResponseCode() == HttpURLConnection.HTTP_NOT_MODIFIED) {
Log.i(TAG, "Already have latest update");
return null;
}
int responseCode = connection.getResponseCode();
Log.i(TAG, "HTTP response code " + responseCode);

if (responseCode == HttpURLConnection.HTTP_NOT_FOUND) {
Log.i(TAG, "Latest update not found");
return null;
}

if (responseCode == HttpURLConnection.HTTP_NOT_MODIFIED) {
Log.i(TAG, "Already have latest update");
return null;
}

try (InputStream input = connection.getInputStream()) {
Log.i(TAG, "Downloading update " + unresolvedURL);
try (OutputStream output = new FileOutputStream(localFile)) {
int count;
Expand Down