Skip to content

Change FlutterPluginsLibraryManager to use Dart plugin #5992

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
stevemessick opened this issue Feb 24, 2022 · 1 comment
Closed

Change FlutterPluginsLibraryManager to use Dart plugin #5992

stevemessick opened this issue Feb 24, 2022 · 1 comment
Milestone

Comments

@stevemessick
Copy link
Member

In order to close #5614 we added some code that uses the package config file instead of the packages file, but it does not implement a proper cache. We were (and still are) using the code in the Dart plugin. Once the Dart plugin is updated we want to resume using that code to load the package config file. This un-cached code will only be used in the unlikely chance that we generate a project that does not have a. .packages file prior to the Dart plugin being updated.

@stevemessick stevemessick added this to the M67 milestone Feb 24, 2022
@stevemessick
Copy link
Member Author

@jwren The Dart plugin still uses .packages in one place. That's going to break when pub stops generating it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant